Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Commit 6461b8a

Browse files
author
alexandergoncharov
committed
Replace App Store version with binary version in docs
1 parent 840f25f commit 6461b8a

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ code-push release-cordova MyApp-ios ios
160160
code-push release-cordova MyApp-Android android
161161
```
162162

163-
*NOTE: When releasing updates to CodePush, you do not need to bump your app's version in the `config.xml` file, since you aren't modifying the app store version at all. You only need to bump this version when you upgrade Cordova and/or one of your plugins, at which point, you need to release an update to the native store(s). CodePush will automatically generate a "label" for each release you make (e.g. `v3`) in order to help identify it within your release history.*
163+
*NOTE: When releasing updates to CodePush, you do not need to bump your app's version in the `config.xml` file, since you aren't modifying the binary version at all. You only need to bump this version when you upgrade Cordova and/or one of your plugins, at which point, you need to release an update to the native store(s). CodePush will automatically generate a "label" for each release you make (e.g. `v3`) in order to help identify it within your release history.*
164164

165165
The `release-cordova` command enables such a simple workflow because it understands the standard layout of a Cordova app, and therefore, can generate your update and know exactly which files to upload. Additionally, in order to support flexible release strategies, the `release-cordova` command exposes numerous optional parameters that let you customize how the update should be distributed to your end users (e.g. Which binary versions are compatible with it? Should the release be viewed as mandatory?).
166166

samples/advanced/www/js/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ var app = {
3535
onDeviceReady: function () {
3636
// Migrate data from older versions
3737
window.codePush.getCurrentPackage(function (currentPackage) {
38-
// getCurrentPackage returns null if no update was installed (app store version)
38+
// getCurrentPackage returns null if no update was installed (binary version)
3939
if (currentPackage && currentPackage.isFirstRun) {
4040
// First run after an update, migrate data
4141
if (currentPackage.appVersion === "1.0.0") {
42-
// migrate data from store version to version 1.0.0
42+
// migrate data from binary version to version 1.0.0
4343
} else if (currentPackage.appVersion === "2.0.0") {
4444
// migrate data to version 2.0.0
4545
}

src/android/CodePush.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ protected Void doInBackground(Void... params) {
227227

228228
private boolean execNotifyApplicationReady(CallbackContext callbackContext) {
229229
if (this.codePushPackageManager.isBinaryFirstRun()) {
230-
// Report first run of a store version app
230+
// Report first run of a binary version app
231231
this.codePushPackageManager.saveBinaryFirstRunFlag();
232232
try {
233233
String appVersion = Utilities.getAppVersionName(cordova.getActivity());

src/ios/CodePush.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ - (void)handleUnconfirmedInstall:(BOOL)navigate {
129129
CodePushPackageMetadata* currentMetadata = [CodePushPackageManager getCurrentPackageMetadata];
130130
bool revertSuccess = (nil != currentMetadata && [self loadPackage:currentMetadata.localPath]);
131131
if (!revertSuccess) {
132-
/* first update failed, go back to store version */
132+
/* first update failed, go back to binary version */
133133
[self loadStoreVersion];
134134
}
135135
}
@@ -139,7 +139,7 @@ - (void)handleUnconfirmedInstall:(BOOL)navigate {
139139
- (void)notifyApplicationReady:(CDVInvokedUrlCommand *)command {
140140
[self.commandDelegate runInBackground:^{
141141
if ([CodePushPackageManager isBinaryFirstRun]) {
142-
// Report first run of a store version app
142+
// Report first run of a binary version app
143143
[CodePushPackageManager markBinaryFirstRunFlag];
144144
NSString* appVersion = [Utilities getApplicationVersion];
145145
NSString* deploymentKey = ((CDVViewController *)self.viewController).settings[DeploymentKeyPreference];

0 commit comments

Comments
 (0)