Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Commit af05245

Browse files
authored
Merge pull request #3822 from microsoft/lamil/fixTests
Lamil/fix tests
2 parents af41037 + b8ec578 commit af05245

2 files changed

Lines changed: 2 additions & 12 deletions

File tree

samples/csharp/assistants/hospitality-assistant/VirtualAssistantSample/Adapters/DefaultAdapter.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ public DefaultAdapter(
6868
Use(new EventDebuggerMiddleware());
6969
Use(new SetSpeakMiddleware());
7070
Use(new ProactiveStateMiddleware(proactiveState));
71-
Use(new FeedbackMiddleware(conversationState, telemetryClient, new FeedbackOptions()));
7271
}
7372

7473
private async Task HandleTurnErrorAsync(ITurnContext turnContext, Exception exception)

sdk/csharp/Directory.Build.props

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,20 +36,15 @@
3636
<DebugType>full</DebugType>
3737
<DebugSymbols>true</DebugSymbols>
3838
</PropertyGroup>
39-
40-
<PropertyGroup>
41-
<PackageIcon>icon.png</PackageIcon>
42-
</PropertyGroup>
39+
4340
<ItemGroup>
4441
<None Include="images\icon.png" Pack="true" PackagePath="\"/>
4542
</ItemGroup>
4643

4744
<PropertyGroup>
4845
<!-- Rules found at: https://aka.ms/Microsoft-NuGet-Compliance -->
4946
<PackageProjectUrl>https://github.com/Microsoft/botframework-solutions</PackageProjectUrl>
50-
51-
<PackageLicenseUrl>https://raw.githubusercontent.com/microsoft/botframework-solutions/master/LICENSE</PackageLicenseUrl>
52-
<PackageIconUrl>https://raw.githubusercontent.com/microsoft/botframework-sdk/main/icon.png</PackageIconUrl>
47+
<PackageIconUrl>https://raw.githubusercontent.com/microsoft/botframework-sdk/master/icon.png</PackageIconUrl>
5348
<PackageLicenseUrl>https://raw.githubusercontent.com/microsoft/botframework-solutions/master/LICENSE</PackageLicenseUrl>
5449
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
5550
<PackageIcon>icon.png</PackageIcon>
@@ -65,8 +60,4 @@
6560
<NoWarn>$(NoWarn);NU5125;NU1701;8002</NoWarn>
6661
</PropertyGroup>
6762

68-
<ItemGroup Condition="'$(GeneratePackageOnBuild)' == 'True'">
69-
<None Include="icon.png" Pack="true" PackagePath="\" />
70-
</ItemGroup>
71-
7263
</Project>

0 commit comments

Comments
 (0)