avoid unnecessary copy for rcutils_char_array_vsprintf. (ros2#412)

fujitatomoya · web-flow · commit 1db1f16a4937 · 2023-03-02T08:20:44.000-08:00
Signed-off-by: Tomoya Fujita &lt;Tomoya.Fujita@sony.com&gt;
diff --git a/src/logging.c b/src/logging.c
@@ -1311,14 +1311,11 @@ void rcutils_logging_console_output_handler(
   }
 
   if (RCUTILS_RET_OK == status) {
-    va_list args_clone;
-    va_copy(args_clone, *args);
-    status = rcutils_char_array_vsprintf(&msg_array, format, args_clone);
+    status = rcutils_char_array_vsprintf(&msg_array, format, *args);
     if (RCUTILS_RET_OK != status) {
       RCUTILS_SAFE_FWRITE_TO_STDERR_WITH_FORMAT_STRING(
         "Error: rcutils_char_array_vsprintf failed with: %d\n", status);
     }
-    va_end(args_clone);
   }
 
   if (RCUTILS_RET_OK == status) {

Original file line number	Diff line number	Diff line change
`@@ -1311,14 +1311,11 @@ void rcutils_logging_console_output_handler(`
`1311`	`1311`	`}`
`1312`	`1312`
`1313`	`1313`	`if (RCUTILS_RET_OK == status) {`
`1314`		`- va_list args_clone;`
`1315`		`- va_copy(args_clone, *args);`
`1316`		`- status = rcutils_char_array_vsprintf(&msg_array, format, args_clone);`
	`1314`	`+ status = rcutils_char_array_vsprintf(&msg_array, format, *args);`
`1317`	`1315`	`if (RCUTILS_RET_OK != status) {`
`1318`	`1316`	`RCUTILS_SAFE_FWRITE_TO_STDERR_WITH_FORMAT_STRING(`
`1319`	`1317`	`"Error: rcutils_char_array_vsprintf failed with: %d\n", status);`
`1320`	`1318`	`}`
`1321`		`- va_end(args_clone);`
`1322`	`1319`	`}`
`1323`	`1320`
`1324`	`1321`	`if (RCUTILS_RET_OK == status) {`