add emmet core version check test

Author: esoteric-ephemera

mp_api/client/core/utils.py

@@ -24,6 +24,10 @@ def _compare_emmet_ver(
         _compare_emmet_ver("0.84.0rc0","<") returns
         emmet.core.__version__ < "0.84.0rc0"
 
+    This function may not be used anywhere in the client, but it should
+    be preserved for future use, in case some degree of backwards
+    compatibility or feature buy-in is needed.
+
     Parameters
     -----------
     ref_version : str

tests/core/test_utils.py

@@ -1,15 +1,36 @@
 """Test client core utilities."""
 
+from packaging.version import parse as parse_version
 import pytest
 
 from emmet.core.mpid import MPID, AlphaID
 
-from mp_api.client.core.utils import validate_ids
-from mp_api.client.core.settings import MAPIClientSettings
+
+def test_emmet_core_version_checks(monkeypatch : pytest.MonkeyPatch):
+
+    ref_ver = (1,2,"3rc5")
+    ref_ver_str = ".".join(str(x) for x in ref_ver)
+
+    import emmet.core
+    monkeypatch.setattr(emmet.core,"__version__",ref_ver_str)
+    from mp_api.client.core.utils import _compare_emmet_ver
+
+    assert _compare_emmet_ver(ref_ver_str,"==")
+
+    next_ver = ".".join(str(x) for x in [ref_ver[0] + 1,*ref_ver[1:]])
+    assert _compare_emmet_ver(next_ver,"<")
+    assert _compare_emmet_ver(next_ver,"<=")
+
+    prior_ver = ".".join(str(x) for x in [ref_ver[0],ref_ver[1]-1,*ref_ver[2:]])
+    assert _compare_emmet_ver(prior_ver,">")
+    assert _compare_emmet_ver(prior_ver,">=")
 
 def test_id_validation():
-    max_num_idxs = MAPIClientSettings().MAX_LIST_LENGTH
 
+    from mp_api.client.core.utils import validate_ids
+    from mp_api.client.core.settings import MAPIClientSettings
+
+    max_num_idxs = MAPIClientSettings().MAX_LIST_LENGTH
 
     with pytest.raises(ValueError,match="too long"):
         _ = validate_ids(
@@ -30,4 +51,4 @@ def test_id_validation():
         for x in validate_ids(
             [y + AlphaID._cut_point for y in range(max_num_idxs)]
         )
-    )    
+    )