Skip to content

Commit 33931b7

Browse files
improve documentation around methods
1 parent 2f38ac3 commit 33931b7

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

mp_api/client/core/_oxygen_evolution.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,14 @@ class OxygenEvolution:
2222
2323
Parameters
2424
-----------
25+
cache_file : Path or None
26+
If a Path, the path to the file at which NIST JANAF data is cached / retrieved.
27+
If None, no caching is performed.
2528
"""
2629

2730
def __init__(
2831
self,
29-
cache_file: Path | None = DEFAULT_CACHE_FILE,
32+
cache_file: Path | None = None, # DEFAULT_CACHE_FILE,
3033
):
3134
self._spline_pars = None
3235
self.cache_file = cache_file
@@ -78,6 +81,11 @@ def get_chempot_temp_data(
7881
temp_K = janaf_data["T(K)"].to_numpy()
7982
entropy_dimless = janaf_data["S"].to_numpy() / (Boltzmann * Avogadro)
8083

84+
# Note that the ideal gas contribution to the chemical potential is
85+
# (Gibbs-Helmholtz relation)
86+
# G(p, T)/N = G(p_0, T_0)/N + k_B T ln(p/p_0)
87+
# where G(p_0, T_0)/N is a reference chemical potential for the system
88+
# We use the zero temperature energy per atom to approximate this later
8189
mu_mu0 = kB_eV * temp_K * (1.0 + np.log(meas_p / ref_p) - entropy_dimless)
8290
if self.cache_file:
8391
self.cache_file.write_text(

0 commit comments

Comments
 (0)