Skip to content

Commit 303af5c

Browse files
committed
add missing field for patching user settings
1 parent 27726d3 commit 303af5c

1 file changed

Lines changed: 10 additions & 9 deletions

File tree

mp_api/client/routes/_user_settings.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,17 +40,18 @@ def patch_user_settings(self, consumer_id, settings): # pragma: no cover
4040
MPRestError.
4141
"""
4242
body = dict()
43+
valid_fields = [
44+
"institution",
45+
"sector",
46+
"job_role",
47+
"is_email_subscribed",
48+
"agreed_terms",
49+
"message_last_read",
50+
]
4351
for key in settings:
44-
if key not in [
45-
"institution",
46-
"sector",
47-
"job_role",
48-
"is_email_subscribed",
49-
"agreed_terms",
50-
]:
52+
if key not in valid_fields:
5153
raise ValueError(
52-
f"Invalid setting key {key}. Must be one of"
53-
"institution, sector, job_role, is_email_subscribed, agreed_terms"
54+
f"Invalid setting key {key}. Must be one of {valid_fields}"
5455
)
5556
body[f"settings.{key}"] = settings[key]
5657

0 commit comments

Comments
 (0)