refactor: enhance test structure and improve output handling in SolutionAnalyzerTests

Author: glebournault

CodeLineCounter.Tests/SolutionAnalyzerTests.cs

@@ -8,49 +8,82 @@ public class SolutionAnalyzerTest : IDisposable
     {
 
         private readonly string _testDirectory;
+        private readonly string _testSolutionPath;
+        private readonly string _outputPath;
         private bool _disposed;
 
         public SolutionAnalyzerTest()
         {
             _testDirectory = Path.Combine(Path.GetTempPath(), "SolutionAnalyzerTest");
+            _testSolutionPath = Path.Combine(_testDirectory, "TestSolution.sln");
+            _outputPath = _testDirectory;
             Directory.CreateDirectory(_testDirectory);
+            // Create minimal test solution if it doesn't exist
+            if (!File.Exists(_testSolutionPath))
+            {
+                File.WriteAllText(_testSolutionPath, @"
+Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio Version 17
+VisualStudioVersion = 17.0.31903.59
+MinimumVisualStudioVersion = 10.0.40219.1
+Project(""{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}"") = ""TestProject"", ""TestProject\TestProject.csproj"", ""{F60AAFF8-A3B6-4D3C-9372-06A0F1B6F82B}""
+EndProject");
+            }
         }
 
         [Fact]
         public void analyze_and_export_solution_succeeds_with_valid_inputs()
         {
             // Arrange
-            var basePath = FileUtils.GetBasePath();
-            var solutionPath = Path.GetFullPath(Path.Combine(basePath, "..", "..", "..", ".."));
-            solutionPath = Path.Combine(solutionPath, "CodeLineCounter.sln");
+            var solutionPath = _testSolutionPath;
+            var verbose = true;
+            var format = CoreUtils.ExportFormat.CSV;
+            var outputPath = _outputPath;
 
-            var verbose = false;
-            var format = CoreUtils.ExportFormat.JSON;
+            try
+            {
+                // Redirect console output
+                using (StringWriter stringWriter = new StringWriter())
+                {
 
-            // Act & Assert
-            using (var sw = new StringWriter())
+                    Console.SetOut(stringWriter);
+
+                    // Act
+                    var exception = Record.Exception(() =>
+                    {
+                        SolutionAnalyzer.AnalyzeAndExportSolution(_testSolutionPath, verbose, format, outputPath);
+                    });
+
+                    // Assert
+                    Assert.Null(exception);
+                    Assert.True(File.Exists(Path.Combine(outputPath, "TestSolution-CodeMetrics.csv")));
+                }
+
+            }
+            finally
             {
-                Console.SetOut(sw);
-                var exception = Record.Exception(() =>
-                SolutionAnalyzer.AnalyzeAndExportSolution(solutionPath, verbose, format));
+                // Cleanup
 
-                Assert.Null(exception);
+                if (File.Exists(solutionPath))
+                {
+                    File.Delete(solutionPath);
+                }
             }
         }
 
         [Fact]
         public void analyze_and_export_solution_throws_on_invalid_path()
         {
-            // Arrange
-
-            var invalidPath = "";
-            var verbose = false;
-            var format = CoreUtils.ExportFormat.JSON;
-
-            // Act & Assert
             using (var sw = new StringWriter())
             {
                 Console.SetOut(sw);
+                // Arrange
+
+                var invalidPath = "";
+                var verbose = false;
+                var format = CoreUtils.ExportFormat.JSON;
+
+                // Act & Assert
                 var exception = Assert.Throws<UnauthorizedAccessException>(() =>
                 SolutionAnalyzer.AnalyzeAndExportSolution(invalidPath, verbose, format));
 
@@ -89,24 +122,23 @@ public void PerformAnalysis_ShouldReturnCorrectAnalysisResult()
         [Fact]
         public void OutputAnalysisResults_ShouldPrintCorrectOutput()
         {
-            // Arrange
-            var result = new AnalysisResult
-            {
-                Metrics = new List<NamespaceMetrics>(),
-                ProjectTotals = new Dictionary<string, int>(),
-                TotalLines = 1000,
-                TotalFiles = 10,
-                DuplicationMap = new List<DuplicationCode>(),
-                DependencyList = new List<DependencyRelation>(),
-                ProcessingTime = TimeSpan.FromSeconds(10),
-                SolutionFileName = "CodeLineCounter.sln",
-                DuplicatedLines = 100
-            };
-            var verbose = true;
-
             using (var sw = new StringWriter())
             {
                 Console.SetOut(sw);
+                // Arrange
+                var result = new AnalysisResult
+                {
+                    Metrics = new List<NamespaceMetrics>(),
+                    ProjectTotals = new Dictionary<string, int>(),
+                    TotalLines = 1000,
+                    TotalFiles = 10,
+                    DuplicationMap = new List<DuplicationCode>(),
+                    DependencyList = new List<DependencyRelation>(),
+                    ProcessingTime = TimeSpan.FromSeconds(10),
+                    SolutionFileName = "CodeLineCounter.sln",
+                    DuplicatedLines = 100
+                };
+                var verbose = true;
 
                 // Act
                 SolutionAnalyzer.OutputAnalysisResults(result, verbose);
@@ -124,40 +156,39 @@ public void OutputAnalysisResults_ShouldPrintCorrectOutput()
         [Fact]
         public void OutputDetailedMetrics_ShouldPrintMetricsAndProjectTotals()
         {
-            // Arrange
-            var metrics = new List<NamespaceMetrics>
-            {
-                new NamespaceMetrics
-                {
-                    ProjectName = "Project1",
-                    ProjectPath = "/path/to/project1",
-                    NamespaceName = "Namespace1",
-                    FileName = "File1.cs",
-                    FilePath = "/path/to/project1/File1.cs",
-                    LineCount = 100,
-                    CyclomaticComplexity = 10
-                },
-                new NamespaceMetrics
-                {
-                    ProjectName = "Project2",
-                    ProjectPath = "/path/to/project2",
-                    NamespaceName = "Namespace2",
-                    FileName = "File2.cs",
-                    FilePath = "/path/to/project2/File2.cs",
-                    LineCount = 200,
-                    CyclomaticComplexity = 20
-                }
-            };
-
-            var projectTotals = new Dictionary<string, int>
-            {
-                { "Project1", 100 },
-                { "Project2", 200 }
-            };
-
             using (var sw = new StringWriter())
             {
                 Console.SetOut(sw);
+                // Arrange
+                var metrics = new List<NamespaceMetrics>
+                {
+                    new NamespaceMetrics
+                    {
+                        ProjectName = "Project1",
+                        ProjectPath = "/path/to/project1",
+                        NamespaceName = "Namespace1",
+                        FileName = "File1.cs",
+                        FilePath = "/path/to/project1/File1.cs",
+                        LineCount = 100,
+                        CyclomaticComplexity = 10
+                    },
+                    new NamespaceMetrics
+                    {
+                        ProjectName = "Project2",
+                        ProjectPath = "/path/to/project2",
+                        NamespaceName = "Namespace2",
+                        FileName = "File2.cs",
+                        FilePath = "/path/to/project2/File2.cs",
+                        LineCount = 200,
+                        CyclomaticComplexity = 20
+                    }
+                };
+
+                var projectTotals = new Dictionary<string, int>
+                {
+                    { "Project1", 100 },
+                    { "Project2", 200 }
+                };
 
                 // Act
                 SolutionAnalyzer.OutputDetailedMetrics(metrics, projectTotals);
@@ -177,7 +208,7 @@ public void OutputDetailedMetrics_ShouldPrintMetricsAndProjectTotals()
         [Fact]
         public void export_results_with_valid_input_exports_all_files()
         {
-          // Act
+            // Act
             using (var sw = new StringWriter())
             {
                 // Arrange
@@ -214,6 +245,7 @@ protected virtual void Dispose(bool disposing)
                 if (disposing && Directory.Exists(_testDirectory))
                 {
                     // Dispose managed resources
+                    File.Delete(_testSolutionPath);
                     Directory.Delete(_testDirectory, true);
                 }