patch 9.2.0246: memory leak in globpath()

huanghuihui0904 · chrisbra · commit 418400075ac9 · 2026-03-25T19:51:42.000Z
Problem:  memory leak in globpath()
Solution: Free the individual allocated strings when ga_grow() fails
          (Huihui Huang)

closes: #19817

Signed-off-by: Huihui Huang &lt;625173@qq.com&gt;
Signed-off-by: Christian Brabandt &lt;cb@256bit.org&gt;
diff --git a/src/cmdexpand.c b/src/cmdexpand.c
@@ -4219,6 +4219,11 @@ globpath(
 			++ga->ga_len;
 		    }
 		}
+		else
+		{
+		    FreeWild(num_p, p);
+		    p = NULL;
+		}
 		vim_free(p);
 	    }
 	}
diff --git a/src/version.c b/src/version.c
@@ -734,6 +734,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    246,
 /**/
     245,
 /**/

Original file line number	Diff line number	Diff line change
`@@ -4219,6 +4219,11 @@ globpath(`
`4219`	`4219`	`++ga->ga_len;`
`4220`	`4220`	`}`
`4221`	`4221`	`}`
	`4222`	`+ else`
	`4223`	`+ {`
	`4224`	`+ FreeWild(num_p, p);`
	`4225`	`+ p = NULL;`
	`4226`	`+ }`
`4222`	`4227`	`vim_free(p);`
`4223`	`4228`	`}`
`4224`	`4229`	`}`