Skip to content

Commit 2e1f757

Browse files
committed
patch 9.1.0978: GUI tests sometimes fail when setting 'scroll' options
Problem: GUI tests sometimes fail when setting 'scroll' options Solution: decrease the 'scroll' and 'scrolljump' option value from 20 to 15, in case the Gui window is not large enough to handle 20. tests: decrease the scroll and scrolljump values the gui tests sometimes fail with: ``` From test_options_all.vim: Found errors in Test_opt_set_scroll(): Caught exception in Test_opt_set_scroll(): Vim(set):E49: Invalid scroll size: scroll=20 @ command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[617]..function RunTheTest[57]..Test_opt_set_scroll, line 7 Found errors in Test_opt_set_scrolljump(): Caught exception in Test_opt_set_scrolljump(): Vim(set):E49: Invalid scroll size: scrolljump=20 @ command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[617]..function RunTheTest[57]..Test_opt_set_scrolljump, line 9 ``` closes: #16337 Signed-off-by: Christian Brabandt <cb@256bit.org>
1 parent 32b7e3a commit 2e1f757

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/testdir/gen_opt_test.vim

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ let test_values = {
8888
\ 'numberwidth': [[1, 4, 8, 10, 11, 20], [-1, 0, 21]],
8989
\ 'regexpengine': [[0, 1, 2], [-1, 3, 999]],
9090
\ 'report': [[0, 1, 2, 9999], [-1]],
91-
\ 'scroll': [[0, 1, 2, 20], [-1, 999]],
92-
\ 'scrolljump': [[-100, -1, 0, 1, 2, 20], [-101, 999]],
91+
\ 'scroll': [[0, 1, 2, 15], [-1, 999]],
92+
\ 'scrolljump': [[-100, -1, 0, 1, 2, 15], [-101, 999]],
9393
\ 'scrolloff': [[0, 1, 8, 999], [-1]],
9494
\ 'shiftwidth': [[0, 1, 8, 999], [-1]],
9595
\ 'sidescroll': [[0, 1, 8, 999], [-1]],

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -704,6 +704,8 @@ static char *(features[]) =
704704

705705
static int included_patches[] =
706706
{ /* Add new patch number below this line */
707+
/**/
708+
978,
707709
/**/
708710
977,
709711
/**/

0 commit comments

Comments
 (0)