Merge pull request #40 from luizfonseca/fix/backwards-compatibility

fix: backwards compatibility when missing `teams: []string{}` in the JWT

Author: luizfonseca

internal/pkg/jwt/jwt.go

@@ -32,11 +32,21 @@ func ParseTokenString(tokenString, key string) (*PayloadUser, error) {
 		return nil, err
 	}
 	if claims, ok := token.Claims.(jwt.MapClaims); ok && token.Valid {
-		teamFromClaims := claims["teams"].([]interface{})
+		var teamFromClaims []interface{}
+
+		switch claims["teams"].(type) {
+		case []interface{}:
+			teamFromClaims = claims["teams"].([]interface{})
+		case nil:
+			// Backwards compatible with previous tokens, nothing to do
+		}
+
 		teams := make([]string, len(teamFromClaims))
 
 		for i, v := range teamFromClaims {
-			teams[i] = v.(string)
+			if stringValue, ok := v.(string); ok {
+				teams[i] = stringValue
+			}
 		}
 
 		return &PayloadUser{

internal/pkg/jwt/jwt_test.go

@@ -37,6 +37,34 @@ func TestParseTokenString(t *testing.T) {
 	assert.Equal(t, testTeams, payload.Teams)
 }
 
+func TestParseTokenString_EmptyTeams(t *testing.T) {
+	// setup
+	tokenString, _ := GenerateJwtTokenString(id, login, []string{}, key)
+
+	// execution
+	payload, err := ParseTokenString(tokenString, key)
+
+	// assertion
+	assert.NoError(t, err)
+	assert.Equal(t, id, payload.Id)
+	assert.Equal(t, login, payload.Login)
+	assert.Equal(t, payload.Teams, []string{})
+}
+
+func TestParseTokenString_NoTeams(t *testing.T) {
+	// setup
+	tokenString, _ := GenerateJwtTokenString(id, login, nil, key)
+
+	// execution
+	payload, err := ParseTokenString(tokenString, key)
+
+	// assertion
+	assert.NoError(t, err)
+	assert.Equal(t, id, payload.Id)
+	assert.Equal(t, login, payload.Login)
+	assert.Equal(t, payload.Teams, []string{})
+}
+
 func TestParseTokenString_InvalidToken(t *testing.T) {
 	// setup
 	tokenString := "invalidtoken"