Fix hostname validation for a new type. (#968)

Author: dennwc

livekit/sip.go

@@ -311,7 +311,7 @@ func (p *SIPOutboundConfig) Validate() error {
 		return errors.New("no outbound hostname specified")
 	} else if strings.Contains(p.Hostname, "transport=") {
 		return errors.New("trunk transport should be set as a field, not a URI parameter")
-	} else if strings.ContainsAny(p.Hostname, "@;") || strings.HasPrefix(p.Address, "sip:") || strings.HasPrefix(p.Address, "sips:") {
+	} else if strings.ContainsAny(p.Hostname, "@;") || strings.HasPrefix(p.Hostname, "sip:") || strings.HasPrefix(p.Hostname, "sips:") {
 		return errors.New("trunk hostname should be a domain name or IP, not SIP URI")
 	}
 	if err := validateHeaderKeys(p.HeadersToAttributes); err != nil {

rpc/sip_test.go

@@ -104,6 +104,7 @@ func TestNewCreateSIPParticipantRequest(t *testing.T) {
 	}, res)
 
 	r.HidePhoneNumber = false
+	r.SipNumber = tr.Numbers[0]
 	r.Trunk = &livekit.SIPOutboundConfig{
 		Hostname:            tr.Address,
 		Transport:           tr.Transport,
@@ -114,6 +115,11 @@ func TestNewCreateSIPParticipantRequest(t *testing.T) {
 	}
 	r.SipTrunkId = ""
 	exp.SipTrunkId = ""
+	for k, v := range tr.Headers {
+		if _, ok := r.Headers[k]; !ok {
+			r.Headers[k] = v
+		}
+	}
 	exp.ParticipantAttributes[livekit.AttrSIPTrunkID] = ""
 	res, err = NewCreateSIPParticipantRequest("p_123", "call-id", "xyz.sip.livekit.cloud", "url", "token", r, nil)
 	require.NoError(t, err)