avoid using node sync methods

Author: hatemhosny

server/src/broadcast/index.ts

@@ -106,17 +106,17 @@ export const broadcast = ({
     });
   });
 
-  app.get('/channels/:id', (req, res) => {
+  app.get('/channels/:id', async (req, res) => {
     const channel = req.params.id;
     if (channels[channel]) {
       channels[channel].lastAccessed = Date.now();
       const hasData = Object.keys(channels[channel].data || {}).length > 0;
       const views = ['index', 'code', 'result'] as const;
       const view = req.query.view;
       const file = views.find((v) => v === view) || (hasData ? 'index' : 'result');
-      const fileContent = fs
-        .readFileSync(path.join(broadcastDir, `/${file}.html`), 'utf-8')
-        .replaceAll('{{AppUrl}}', appUrl);
+      const fileContent = (
+        await fs.promises.readFile(path.join(broadcastDir, `/${file}.html`), 'utf-8')
+      ).replaceAll('{{AppUrl}}', appUrl);
       res.status(200).send(fileContent);
     } else {
       res.status(404).send('Channel not found!');

server/src/sandbox.ts

@@ -6,19 +6,20 @@ import path from 'node:path';
 import { sandboxVersion } from '../../src/livecodes/html/sandbox/index.ts';
 import { dirname } from './utils.ts';
 
-export const sandbox = ({ hostname, port }: { hostname: string; port: number }) => {
+export const sandbox = async ({ hostname, port }: { hostname: string; port: number }) => {
   const app = express();
 
   app.use(cors());
   app.disable('x-powered-by');
 
   const sandboxDir = path.resolve(dirname, 'sandbox');
   let sandboxVersionDir = path.resolve(sandboxDir, sandboxVersion);
-  fs.readdirSync(sandboxDir).forEach((v) => {
-    if (fs.statSync(path.resolve(sandboxDir, v)).isDirectory()) {
+  const dirs = await fs.promises.readdir(sandboxDir);
+  for (const v of dirs) {
+    if ((await fs.promises.stat(path.resolve(sandboxDir, v))).isDirectory()) {
       sandboxVersionDir = path.resolve(sandboxDir, v);
     }
-  });
+  }
 
   app.use('/', (req, res) => {
     if (req.path === '/') {
@@ -33,11 +34,8 @@ export const sandbox = ({ hostname, port }: { hostname: string; port: number })
         : req.path;
     res.set('Content-Type', 'text/html');
     const filePath = path.resolve(dirname, 'sandbox' + reqPath);
-    if (fs.existsSync(filePath)) {
-      res.status(200).sendFile(filePath);
-      return;
-    }
-    res.status(404).sendFile(path.resolve(sandboxVersionDir, 'index.html'));
+    const onError = () => res.status(404).sendFile(path.resolve(sandboxVersionDir, 'index.html'));
+    res.status(200).sendFile(filePath, onError);
   });
 
   app.listen(port, () => {

server/src/utils.ts

@@ -10,7 +10,7 @@ const getDirname = (metaUrl: string) => path.dirname(fileURLToPath(metaUrl));
 export const dirname = getDirname(import.meta.url);
 export const appDir = path.resolve(dirname, '../../build/');
 
-const getFileContent = async (fullUrl: string) => {
+const getFileContent = (fullUrl: string): Promise<string> => {
   let pathname: string;
   try {
     const url = new URL(fullUrl);
@@ -22,10 +22,9 @@ const getFileContent = async (fullUrl: string) => {
     pathname = 'index.html';
   }
   let filePath = path.resolve(appDir, pathname);
-  if (!fs.existsSync(filePath)) {
-    filePath = path.resolve(appDir, '404.html');
-  }
-  return fs.promises.readFile(filePath, 'utf8');
+  return fs.promises
+    .readFile(filePath, 'utf8')
+    .catch(() => fs.promises.readFile(path.resolve(appDir, '404.html'), 'utf8'));
 };
 
 const convertToWebRequest = (req: express.Request) => {