Skip to content

Commit cb4d4b4

Browse files
committed
build: Don't create user account with specific uid/gid
Using a specific uid/gid for the user account causes problems if the ids clash with anything in the distro image.
1 parent 8e4c31c commit cb4d4b4

6 files changed

Lines changed: 5 additions & 36 deletions

File tree

build/allcross/Dockerfile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,7 @@ RUN apt-get -q -y update && \
5252
xz-utils && \
5353
rm -rf /var/lib/apt/lists/* /tmp/packages.sh /var/cache/* /var/log/dpkg.log
5454

55-
ARG uid
56-
ARG gid
57-
58-
RUN groupadd --gid $gid linuxppc
59-
RUN useradd --uid $uid --gid $gid linuxppc
55+
RUN useradd linuxppc
6056
USER linuxppc
6157

6258
COPY scripts/container-build.sh /bin/container-build.sh

build/docs/Dockerfile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,7 @@ RUN apt-get -q -y update && \
2929
&& \
3030
rm -rf /var/lib/apt/lists/* /var/cache/* /var/log/dpkg.log
3131

32-
ARG uid
33-
ARG gid
34-
35-
RUN groupadd --gid $gid linuxppc
36-
RUN useradd --uid $uid --gid $gid linuxppc
32+
RUN useradd linuxppc
3733
USER linuxppc
3834

3935
COPY scripts/container-build.sh /bin/container-build.sh

build/fedora/Dockerfile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,7 @@ RUN dnf -y install --setopt=install_weak_deps=False \
4141
COPY fedora/make-links.sh /tmp/make-links.sh
4242
RUN /tmp/make-links.sh ${compiler_version} && rm /tmp/make-links.sh
4343

44-
ARG uid
45-
ARG gid
46-
47-
RUN groupadd --gid $gid linuxppc
48-
RUN useradd --uid $uid --gid $gid linuxppc
44+
RUN useradd linuxppc
4945
USER linuxppc
5046

5147
COPY scripts/container-build.sh /bin/container-build.sh

build/korg/Dockerfile

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,7 @@ RUN curl -sSL $base_url/$tar_file > $tar_file && \
5151
COPY korg/make-links.sh /tmp/make-links.sh
5252
RUN /tmp/make-links.sh ${compiler_version} && rm /tmp/make-links.sh
5353

54-
ARG uid
55-
ARG gid
56-
57-
RUN userdel -r ubuntu || true
58-
RUN groupadd --gid $gid linuxppc
59-
RUN useradd --uid $uid --gid $gid linuxppc
54+
RUN useradd linuxppc
6055
USER linuxppc
6156

6257
COPY scripts/container-build.sh /bin/container-build.sh

build/scripts/image.sh

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -117,23 +117,13 @@ if [[ -n "$https_proxy" ]]; then
117117
cmd+="--build-arg https_proxy=$https_proxy "
118118
fi
119119

120-
if [[ -z "$UID" ]]; then
121-
UID=$(id -u)
122-
fi
123-
124-
if [[ -z "$GID" ]]; then
125-
GID=$(id -g)
126-
fi
127-
128120
if [[ "$distro" == "korg" ]]; then
129121
cmd+="--build-arg compiler_version=$version "
130122
arch=$(uname -m)
131123
cmd+="--build-arg base_url=https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/${arch}/${version}/ "
132124
cmd+="--build-arg tar_file=${arch}-gcc-${version}-nolibc-powerpc64-linux.tar.xz "
133125
fi
134126

135-
cmd+="--build-arg uid=$UID "
136-
cmd+="--build-arg gid=$GID "
137127
cmd+="--build-arg from=$from "
138128
cmd+="--build-arg apt_mirror=$APT_MIRROR "
139129
cmd+="-t $image ."

build/ubuntu/Dockerfile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,7 @@ RUN apt-get -q -y update && \
5252
COPY ubuntu/make-links.sh /tmp/make-links.sh
5353
RUN /tmp/make-links.sh ${compiler_version} && rm /tmp/make-links.sh
5454

55-
ARG uid
56-
ARG gid
57-
58-
RUN groupadd --gid $gid linuxppc
59-
RUN useradd --uid $uid --gid $gid linuxppc
55+
RUN useradd linuxppc
6056
USER linuxppc
6157

6258
COPY scripts/container-build.sh /bin/container-build.sh

0 commit comments

Comments
 (0)