Added Support for Quoted Keys and JobProperties in CREATE TRIGGER (#200)

* Added Support for Quoted Keys and JobProperties in CREATE TRIGGER

* Makefile Changes

* Fix Tests

* Fix Another Test

---------

Co-authored-by: Shrinand Thakkar <sthakkar@linkedin.com>

Author: srnand

Makefile

@@ -41,12 +41,14 @@ quickstart: build deploy
 deploy-demo: deploy
 	kubectl apply -f ./deploy/samples/demodb.yaml
 	kubectl apply -f ./deploy/samples/tabletriggers.yaml
+	kubectl apply -f ./deploy/samples/retl-job-template.yaml
 	kubectl apply -f ./deploy/samples/crontrigger.yaml
 	kubectl apply -f ./deploy/samples/user-jobs.yaml
 
 undeploy-demo: undeploy
 	kubectl delete -f ./deploy/samples/demodb.yaml || echo "skipping"
 	kubectl delete -f ./deploy/samples/tabletriggers.yaml || echo "skipping"
+	kubectl delete -f ./deploy/samples/retl-job-template.yaml || echo "skipping"
 	kubectl delete -f ./deploy/samples/crontrigger.yaml || echo "skipping"
 
 deploy-flink: deploy

deploy/samples/retl-job-template.yaml

@@ -0,0 +1,27 @@
+apiVersion: hoptimator.linkedin.com/v1alpha1
+kind: JobTemplate
+metadata:
+  name: retl-job-template
+  namespace: default
+spec:
+  yaml: |
+    apiVersion: batch/v1
+    kind: Job
+    metadata:
+      name: {{name}}-job
+    spec:
+      template:
+        spec:
+          containers:
+          - name: hello
+            image: alpine/k8s:1.33.0
+            env:
+              - name: TABLE_TRIGGER_NAME
+                value: "{{name}}-trigger"
+              - name: SOURCE_TABLE_NAME
+                value: "{{offline.table.name}}"
+              - name: ONLINE_TABLE_NAME
+                value: "{{job.properties.online.table.name}}"
+            command: ["bash",  "-c", "echo {{name}}-trigger fired at `date`"]
+          restartPolicy: Never
+      backoffLimit: 4

hoptimator-jdbc/src/main/codegen/includes/parserImpls.ftl

@@ -54,13 +54,20 @@ SqlNodeList Options() :
 
 void Option(List<SqlNode> list) :
 {
-    final SqlIdentifier id;
+    final SqlNode key;
     final SqlNode value;
 }
 {
-    id = SimpleIdentifier()
+    (
+        key = CompoundIdentifier()
+    |
+        <QUOTED_STRING> {
+            key = SqlLiteral.createCharString(
+                SqlParserUtil.parseString(token.image), getPos());
+        }
+    )
     value = Literal() {
-        list.add(id);
+        list.add(key);
         list.add(value);
     }
 }

hoptimator-jdbc/src/main/java/com/linkedin/hoptimator/jdbc/HoptimatorDdlUtils.java

@@ -173,9 +173,15 @@ static Map<String, String> options(SqlNodeList optionList) {
     Map<String, String> options = new HashMap<>();
     if (optionList != null) {
       for (int i = 0; i < optionList.size() - 1; i += 2) {
-        SqlIdentifier k = (SqlIdentifier) optionList.get(i);
+        SqlNode k = optionList.get(i);
         SqlLiteral v = (SqlLiteral) optionList.get(i + 1);
-        options.put(k.getSimple(), v.getValueAs(String.class));
+        String keyStr;
+        if (k instanceof SqlIdentifier) {
+          keyStr = String.join(".", ((SqlIdentifier) k).names);
+        } else {
+          keyStr = ((SqlLiteral) k).getValueAs(String.class);
+        }
+        options.put(keyStr, v.getValueAs(String.class));
       }
     }
     return options;