helper.pl - detect sizeof without brackets

karel-m · sjaeckel · commit 153b8979842f · 2017-12-05T09:21:27.000+01:00
(cherry picked from commit b7e35e9)
diff --git a/helper.pl b/helper.pl
@@ -55,6 +55,7 @@ sub check_source {
       push @{$troubles->{unwanted_strcmp}},  $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bstrcmp\s*\(/;
       push @{$troubles->{unwanted_clock}},   $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bclock\s*\(/;
       push @{$troubles->{unwanted_qsort}},   $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bqsort\s*\(/;
+      push @{$troubles->{sizeof_no_brackets}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bsizeof\s*[^\(]/;
       if ($file =~ m|src/.*\.c$| &&
           $file !~ m|src/ciphers/.*\.c$| &&
           $file !~ m|src/hashes/.*\.c$| &&
diff --git a/src/ciphers/des.c b/src/ciphers/des.c
@@ -1383,7 +1383,7 @@ static void cookey(const ulong32 *raw1, ulong32 *keyout)
         *cook++ |= (*raw1 & 0x0000003fL);
     }
 
-    XMEMCPY(keyout, dough, sizeof dough);
+    XMEMCPY(keyout, dough, sizeof(dough));
 }
 
 #ifdef LTC_CLEAN_STACK

Original file line number	Diff line number	Diff line change
`@@ -1383,7 +1383,7 @@ static void cookey(const ulong32 raw1, ulong32 keyout)`
`1383`	`1383`	`cook++ \|= (raw1 & 0x0000003fL);`
`1384`	`1384`	`}`
`1385`	`1385`
`1386`		`- XMEMCPY(keyout, dough, sizeof dough);`
	`1386`	`+ XMEMCPY(keyout, dough, sizeof(dough));`
`1387`	`1387`	`}`
`1388`	`1388`
`1389`	`1389`	`#ifdef LTC_CLEAN_STACK`