Update Mypy config.

Migrate to pyproject.toml.

Add types-cffi stubs.

Author: HexDecimal

.github/workflows/python-package.yml

@@ -69,7 +69,7 @@ jobs:
         uses: liskin/gh-problem-matcher-wrap@v2
         with:
           linters: mypy
-          run: mypy --show-column-numbers .
+          run: mypy --show-column-numbers
 
   # This makes sure that the latest versions of the SDL headers parse correctly.
   parse_sdl:

build_libtcod.py

@@ -9,7 +9,7 @@
 from pathlib import Path
 from typing import Any, Dict, Iterable, Iterator, List, Set, Tuple, Union
 
-from cffi import FFI  # type: ignore
+from cffi import FFI
 
 sys.path.append(str(Path(__file__).parent))  # Allow importing local modules.
 

pyproject.toml

@@ -101,6 +101,39 @@ filterwarnings = [
     "ignore:This class may perform poorly and is no longer needed.::tcod.map",
 ]
 
+[tool.mypy]
+files = ["."]
+python_version = 3.8
+warn_unused_configs = true
+show_error_codes = true
+disallow_subclassing_any = true
+disallow_any_generics = true
+disallow_untyped_calls = true
+disallow_untyped_defs = true
+disallow_incomplete_defs = true
+check_untyped_defs = true
+disallow_untyped_decorators = true
+no_implicit_optional = true
+warn_redundant_casts = true
+warn_unused_ignores = true
+warn_return_any = true
+implicit_reexport = false
+strict_equality = true
+exclude = [
+    "build/",
+    "venv/",
+    "libtcod/",
+    "docs/",
+    "distribution/",
+    "termbox/",
+    "samples_libtcodpy.py",
+]
+
+[[tool.mypy.overrides]]
+module = "numpy.*"
+ignore_missing_imports = true
+
+
 [tool.ruff]
 # https://beta.ruff.rs/docs/rules/
 select = [

requirements.txt

@@ -3,6 +3,7 @@ numpy>=1.21.4
 pycparser>=2.14
 requests>=2.28.1
 setuptools==65.5.1
+types-cffi
 types-requests
 types-setuptools
 types-tabulate

tcod/loader.py

@@ -7,7 +7,7 @@
 from pathlib import Path
 from typing import Any  # noqa: F401
 
-import cffi  # type: ignore
+import cffi
 
 __sdl_version__ = ""
 
@@ -29,12 +29,13 @@
 def verify_dependencies() -> None:
     """Try to make sure dependencies exist on this system."""
     if sys.platform == "win32":
-        lib_test = ffi_check.dlopen("SDL2.dll")  # Make sure SDL2.dll is here.
-        version = ffi_check.new("struct SDL_version*")
+        lib_test: Any = ffi_check.dlopen("SDL2.dll")  # Make sure SDL2.dll is here.
+        version: Any = ffi_check.new("struct SDL_version*")
         lib_test.SDL_GetVersion(version)  # Need to check this version.
-        version = version.major, version.minor, version.patch
-        if version < (2, 0, 5):
-            raise RuntimeError("Tried to load an old version of SDL %r" % (version,))
+        version_tuple = version.major, version.minor, version.patch
+        if version_tuple < (2, 0, 5):
+            msg = f"Tried to load an old version of SDL {version_tuple!r}"
+            raise RuntimeError(msg)
 
 
 def get_architecture() -> str: