Fixes #98 (#114)

Author: k1sul1

classes/class-cpt-wplf-form.php

@@ -444,9 +444,8 @@ public function metabox_form_fields() {
    * Meta box callback for submit email meta box
    */
   public function metabox_submit_email( $post ) {
-    // get post meta
     $meta = get_post_meta( $post->ID );
-    $email_enabled = isset( $meta['_wplf_email_copy_enabled'] ) ? $meta['_wplf_email_copy_enabled'][0] : true;
+    $email_enabled = ! empty( $meta['_wplf_email_copy_enabled'] ) ? (int) $meta['_wplf_email_copy_enabled'][0] : 0;
     $email_copy_to = isset( $meta['_wplf_email_copy_to'] ) ? $meta['_wplf_email_copy_to'][0] : '';
     $email_copy_from = isset( $meta['_wplf_email_copy_from'] ) ? $meta['_wplf_email_copy_from'][0] : '';
     $email_copy_from_address = isset( $meta['_wplf_email_copy_from_address'] ) ? $meta['_wplf_email_copy_from_address'][0] : '';
@@ -739,7 +738,7 @@ public function save_cpt( $post_id ) {
     if ( isset( $_POST['wplf_email_copy_enabled'] ) ) {
       update_post_meta( $post_id, '_wplf_email_copy_enabled', $_POST['wplf_email_copy_enabled'] === 'on' );
     } else {
-      update_post_meta( $post_id, '_wplf_email_copy_enabled', false );
+      update_post_meta( $post_id, '_wplf_email_copy_enabled', 0 );
     }
 
     // save email copy

inc/wplf-form-actions.php

@@ -2,6 +2,7 @@
 
 add_action( 'wplf_post_validate_submission', 'wplf_send_email_copy', 20 );
 function wplf_send_email_copy( $return, $submission_id = null ) {
+  // Normally $submission_id is null, but when resending copies it isn't, which is why this check exists
   if ( ! $submission_id ) {
     $submission_id = $return->submission_id;
   }
@@ -15,9 +16,9 @@ function wplf_send_email_copy( $return, $submission_id = null ) {
   $form_meta = get_post_meta( $form_id );
 
   $referrer = esc_url_raw( ( isset( $submission_id ) ) ? get_post_meta( $submission_id, 'referrer', true ) : $_POST['referrer'] );
+  $email_enabled = ! empty( $form_meta['_wplf_email_copy_enabled'] ) ? (int) $form_meta['_wplf_email_copy_enabled'][0] : false;
 
-  if ( ( isset( $form_meta['_wplf_email_copy_enabled'] ) && $form_meta['_wplf_email_copy_enabled'][0] ) || isset( $submission_id ) ) {
-
+  if ( $email_enabled ) {
     $to = isset( $form_meta['_wplf_email_copy_to'] ) ? $form_meta['_wplf_email_copy_to'][0] : get_option( 'admin_email' );
 
     // translators: %submission-id% is replaced with submission id and %referrer% with referrer url