Kad PUT_VALUE response deviating from the spec

[gmelodie]

Description

The spec says that a PUT_VALUE response message should have key and record fields set, however this implementaion does the following instead:

rust-libp2p/protocols/kad/src/protocol.rs

Lines 326 to 333 in 0125fa9

	/// Response to a `PutValue`.
	PutValue {
	/// The key of the record.
	key: record::Key,
	/// Value of the record.
	value: Vec<u8>,
	},
	}

Motivation

It should follow the spec

Current Implementation

Uses key and value

Are you planning to do it yourself in a pull request?

Maybe

[elenaf9]

We construct the record field when we build the actual protobuf:

rust-libp2p/protocols/kad/src/protocol.rs

Lines 434 to 443 in 0125fa9

	KadResponseMsg::PutValue { key, value } => proto::Message {
	type_pb: proto::MessageType::PUT_VALUE,
	key: key.to_vec(),
	record: Some(proto::Record {
	key: key.to_vec(),
	value,
	..proto::Record::default()
	}),
	..proto::Message::default()
	},

[gmelodie]

That seems correct to me indeed... I wonder why my nim parser failed to parse the response from rust-libp2p but succeeded when I had it talk to go-libp2p.