fix(upnp): skip port mapping when an active port mapping is present

This commit aims to fix a bug where a valid listener would be thrown away without attempting a port map. This happens when we have multiple local adapters and the local adapter with the upnp support is not the first one obtained via `NewListenAddr`.
With the new change, we would only skip the listen addr if an `Active Mapping` exists for that same

Pull-Request: #6127.

Author: RolandSherwin

Cargo.lock

@@ -108,7 +108,7 @@ libp2p-swarm-test = { version = "0.6.0", path = "swarm-test" }
 libp2p-tcp = { version = "0.44.0", path = "transports/tcp" }
 libp2p-tls = { version = "0.6.2", path = "transports/tls" }
 libp2p-uds = { version = "0.43.0", path = "transports/uds" }
-libp2p-upnp = { version = "0.5.0", path = "protocols/upnp" }
+libp2p-upnp = { version = "0.5.1", path = "protocols/upnp" }
 libp2p-webrtc = { version = "0.9.0-alpha.1", path = "transports/webrtc" }
 libp2p-webrtc-utils = { version = "0.4.0", path = "misc/webrtc-utils" }
 libp2p-webrtc-websys = { version = "0.4.0", path = "transports/webrtc-websys" }

Cargo.toml

@@ -1,3 +1,11 @@
+## 0.5.1
+
+- Skip port mapping when an active port mapping is present.
+  Previously, the behavior would skip creating new mappings if any mapping 
+  (active or inactive or pending) existed for the same port. Now it correctly only 
+  checks active mappings on the gateway.
+  See [PR 6127](https://github.com/libp2p/rust-libp2p/pull/6127).
+
 ## 0.5.0
 
 - update igd-next to 0.16.1

protocols/upnp/CHANGELOG.md

@@ -3,7 +3,7 @@ name = "libp2p-upnp"
 edition.workspace = true
 rust-version.workspace = true
 description = "UPnP support for libp2p transports"
-version = "0.5.0"
+version = "0.5.1"
 license = "MIT"
 repository = "https://github.com/libp2p/rust-libp2p"
 keywords = ["peer-to-peer", "libp2p", "networking"]

protocols/upnp/Cargo.toml

@@ -270,15 +270,14 @@ impl NetworkBehaviour for Behaviour {
                     return;
                 };
 
-                if let Some((mapping, _state)) = self
-                    .mappings
-                    .iter()
-                    .find(|(mapping, _state)| mapping.internal_addr.port() == addr.port())
-                {
+                if let Some((mapping, _state)) = self.mappings.iter().find(|(mapping, state)| {
+                    matches!(state, MappingState::Active(_))
+                        && mapping.internal_addr.port() == addr.port()
+                }) {
                     tracing::debug!(
                         multiaddress=%multiaddr,
                         mapped_multiaddress=%mapping.multiaddr,
-                        "port from multiaddress is already being mapped"
+                        "port from multiaddress is already mapped on the gateway"
                     );
                     return;
                 }