Change code transaction_non_final to absolute_time_locked.

Author: evoskuil

include/bitcoin/system/error/transaction_error_t.hpp

@@ -47,14 +47,14 @@ enum transaction_error_t
 
     // accept transaction
     unexpected_witness_transaction,
-    transaction_non_final,
     premature_validation,
     unspent_duplicate,
     missing_previous_output,
     double_spend,
     coinbase_maturity,
     spend_exceeds_value,
     transaction_sigop_limit,
+    absolute_time_locked,
     relative_time_locked,
     transaction_weight_limit,
 

src/error/transaction_error_t.cpp

@@ -41,15 +41,15 @@ DEFINE_ERROR_T_MESSAGE_MAP(transaction_error)
 
     // accept transaction
     { unexpected_witness_transaction, "unexpected witness transaction" },
-    { transaction_non_final, "transaction currently non-final" },
     { premature_validation, "transaction validation under checkpoint" },
     { unspent_duplicate, "matching transaction with unspent outputs" },
     { missing_previous_output, "previous output not found" },
     { double_spend, "double spend of input" },
     { coinbase_maturity, "immature coinbase spent" },
     { spend_exceeds_value, "spend exceeds value of inputs" },
     { transaction_sigop_limit, "too many transaction embedded signature operations" },
-    { relative_time_locked, "transaction currently locked" },
+    { absolute_time_locked, "transaction absolute time locked" },
+    { relative_time_locked, "transaction relative time locked" },
     { transaction_weight_limit, "transaction weight limit exceeded" },
 
     // dconfirm transaction

test/error/transaction_error_t.cpp

@@ -114,15 +114,6 @@ BOOST_AUTO_TEST_CASE(transaction_error_t__code__unexpected_witness_transaction__
     BOOST_REQUIRE_EQUAL(ec.message(), "unexpected witness transaction");
 }
 
-BOOST_AUTO_TEST_CASE(transaction_error_t__code__transaction_non_final__true_exected_message)
-{
-    constexpr auto value = error::transaction_non_final;
-    const auto ec = code(value);
-    BOOST_REQUIRE(ec);
-    BOOST_REQUIRE(ec == value);
-    BOOST_REQUIRE_EQUAL(ec.message(), "transaction currently non-final");
-}
-
 BOOST_AUTO_TEST_CASE(transaction_error_t__code__premature_validation__true_exected_message)
 {
     constexpr auto value = error::premature_validation;
@@ -186,13 +177,22 @@ BOOST_AUTO_TEST_CASE(transaction_error_t__code__transaction_sigop_limit__true_ex
     BOOST_REQUIRE_EQUAL(ec.message(), "too many transaction embedded signature operations");
 }
 
+BOOST_AUTO_TEST_CASE(transaction_error_t__code__absolute_time_locked__true_exected_message)
+{
+    constexpr auto value = error::absolute_time_locked;
+    const auto ec = code(value);
+    BOOST_REQUIRE(ec);
+    BOOST_REQUIRE(ec == value);
+    BOOST_REQUIRE_EQUAL(ec.message(), "transaction absolute time locked");
+}
+
 BOOST_AUTO_TEST_CASE(transaction_error_t__code__relative_time_locked__true_exected_message)
 {
     constexpr auto value = error::relative_time_locked;
     const auto ec = code(value);
     BOOST_REQUIRE(ec);
     BOOST_REQUIRE(ec == value);
-    BOOST_REQUIRE_EQUAL(ec.message(), "transaction currently locked");
+    BOOST_REQUIRE_EQUAL(ec.message(), "transaction relative time locked");
 }
 
 BOOST_AUTO_TEST_CASE(transaction_error_t__code__transaction_weight_limit__true_exected_message)