Remove bool param in split(string, bool compress=true).

Author: evoskuil

include/bitcoin/system/data/string.hpp

@@ -39,9 +39,9 @@ constexpr std::string to_string(const data_slice& bytes) NOEXCEPT
 BC_API std::string join(const string_list& tokens,
     const std::string& delimiter=ascii_space) NOEXCEPT;
 
-/// Split text into tokens by the specified delimiter(s).
-/// Compression removes all but a last empty token (after trimming).
-BC_API string_list split(const std::string& text, bool compress=true) NOEXCEPT;
+/// Split text into tokens (whitespace default) by the specified delimiter(s).
+/// Compression (default) removes all but a last empty token (after trimming).
+BC_API string_list split(const std::string& text) NOEXCEPT;
 BC_API string_list split(const std::string& text,
     const std::string& delimiter, bool trim=true, bool compress=true) NOEXCEPT;
 BC_API string_list split(const std::string& text,

src/data/string.cpp

@@ -151,11 +151,11 @@ string_list split(const std::string& text, const std::string& delimiter,
     return split(text, string_list{ delimiter }, trim_tokens, compress);
 }
 
-string_list split(const std::string& text, bool compress) NOEXCEPT
+string_list split(const std::string& text) NOEXCEPT
 {
     // Splitting is prioritized over trimming, because each token is trimmed.
     // So trimming is not an option when splitting on the trim characters.
-    return split(text, ascii_whitespace, ascii_whitespace, compress);
+    return split(text, ascii_whitespace, ascii_whitespace, true);
 }
 
 bool trim_left(std::string& text, const std::string& token) NOEXCEPT

test/data/string.cpp

@@ -142,14 +142,14 @@ BOOST_AUTO_TEST_CASE(string__split0__true_compress__trimmed_compressed)
 {
     const std::string value{ "\t\r\n abc " };
     const string_list expected{ "abc" };
-    BOOST_REQUIRE_EQUAL(system::split(value, true), expected);
+    BOOST_REQUIRE_EQUAL(system::split(value), expected);
 }
 
 BOOST_AUTO_TEST_CASE(string__split0__false_compress__trimmed)
 {
     const std::string value{ " abc \t\r\n" };
     const string_list expected{ "abc" };
-    BOOST_REQUIRE_EQUAL(system::split(value, false), expected);
+    BOOST_REQUIRE_EQUAL(system::split(value, ascii_whitespace, ascii_whitespace, false), expected);
 }
 
 // split1
@@ -589,7 +589,7 @@ BOOST_AUTO_TEST_CASE(string__replace__with_spaces__expected)
     BOOST_REQUIRE_EQUAL(replace(value, "c", " "), 2u);
     BOOST_REQUIRE_EQUAL(value, expected3);
     const string_list expected4{ "def", "", "", "", "", "def" };
-    BOOST_REQUIRE_EQUAL(split(value, false), expected4);
+    BOOST_REQUIRE_EQUAL(split(value, ascii_whitespace, ascii_whitespace, false), expected4);
 }
 
 // replace_copy