Comments.

evoskuil · evoskuil · commit ddcb2cfce877 · 2025-04-17T01:44:54.000-04:00
diff --git a/src/chain/block.cpp b/src/chain/block.cpp
@@ -868,6 +868,7 @@ code block::identify() const NOEXCEPT
     return error::block_success;
 }
 
+// bip141 should be disabled when the node is not accepting witness data.
 code block::identify(const context& ctx) const NOEXCEPT
 {
     const auto bip141 = ctx.is_enabled(bip141_rule);
@@ -911,6 +912,7 @@ code block::check() const NOEXCEPT
 // median_time_past
 
 // TODO: use of get_hash() in is_hash_limit_exceeded makes this thread unsafe.
+// bip141 should be disabled when the node is not accepting witness data.
 code block::check(const context& ctx) const NOEXCEPT
 {
     const auto bip141 = ctx.is_enabled(bip141_rule);

Original file line number	Diff line number	Diff line change
`@@ -868,6 +868,7 @@ code block::identify() const NOEXCEPT`
`868`	`868`	`return error::block_success;`
`869`	`869`	`}`
`870`	`870`
	`871`	`+// bip141 should be disabled when the node is not accepting witness data.`
`871`	`872`	`code block::identify(const context& ctx) const NOEXCEPT`
`872`	`873`	`{`
`873`	`874`	`const auto bip141 = ctx.is_enabled(bip141_rule);`
`@@ -911,6 +912,7 @@ code block::check() const NOEXCEPT`
`911`	`912`	`// median_time_past`
`912`	`913`
`913`	`914`	`// TODO: use of get_hash() in is_hash_limit_exceeded makes this thread unsafe.`
	`915`	`+// bip141 should be disabled when the node is not accepting witness data.`
`914`	`916`	`code block::check(const context& ctx) const NOEXCEPT`
`915`	`917`	`{`
`916`	`918`	`const auto bip141 = ctx.is_enabled(bip141_rule);`