Add missing depromote to shift_left_into.

evoskuil · evoskuil · commit c045763de1cf · 2024-12-21T02:45:48.000-05:00
diff --git a/include/bitcoin/system/impl/math/bits.ipp b/include/bitcoin/system/impl/math/bits.ipp
@@ -294,8 +294,8 @@ template <typename Value, if_unsigned_integral_integer<Value>>
 constexpr void shift_left_into(Value& value, size_t shift, bool overflow) NOEXCEPT
 {
     constexpr auto span = bits<Value>;
-    overflow && shift >= span ? value = 0 :
-        value <<= (shift % span);
+    overflow && shift >= span ? value = 0 : depromote<Value>(
+        value <<= (shift % span));
 }
 
 // signed overloads (shift left of negative is undefined behavior).

Original file line number	Diff line number	Diff line change
`@@ -294,8 +294,8 @@ template <typename Value, if_unsigned_integral_integer<Value>>`
`294`	`294`	`constexpr void shift_left_into(Value& value, size_t shift, bool overflow) NOEXCEPT`
`295`	`295`	`{`
`296`	`296`	`constexpr auto span = bits<Value>;`
`297`		`- overflow && shift >= span ? value = 0 :`
`298`		`- value <<= (shift % span);`
	`297`	`+ overflow && shift >= span ? value = 0 : depromote<Value>(`
	`298`	`+ value <<= (shift % span));`
`299`	`299`	`}`
`300`	`300`
`301`	`301`	`// signed overloads (shift left of negative is undefined behavior).`