Change transaction_non_final error message text.

evoskuil · evoskuil · commit a5e0b683ca1f · 2025-01-12T14:51:53.000-05:00
diff --git a/src/error/transaction_error_t.cpp b/src/error/transaction_error_t.cpp
@@ -41,7 +41,7 @@ DEFINE_ERROR_T_MESSAGE_MAP(transaction_error)
 
     // accept transaction
     { unexpected_witness_transaction, "unexpected witness transaction" },
-    { transaction_non_final, "transaction currently non-final for next block" },
+    { transaction_non_final, "transaction currently non-final" },
     { premature_validation, "transaction validation under checkpoint" },
     { unspent_duplicate, "matching transaction with unspent outputs" },
     { missing_previous_output, "previous output not found" },
diff --git a/test/error/transaction_error_t.cpp b/test/error/transaction_error_t.cpp
@@ -120,7 +120,7 @@ BOOST_AUTO_TEST_CASE(transaction_error_t__code__transaction_non_final__true_exec
     const auto ec = code(value);
     BOOST_REQUIRE(ec);
     BOOST_REQUIRE(ec == value);
-    BOOST_REQUIRE_EQUAL(ec.message(), "transaction currently non-final for next block");
+    BOOST_REQUIRE_EQUAL(ec.message(), "transaction currently non-final");
 }
 
 BOOST_AUTO_TEST_CASE(transaction_error_t__code__premature_validation__true_exected_message)

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ BOOST_AUTO_TEST_CASE(transaction_error_t__code__transaction_non_final__true_exec`
`120`	`120`	`const auto ec = code(value);`
`121`	`121`	`BOOST_REQUIRE(ec);`
`122`	`122`	`BOOST_REQUIRE(ec == value);`
`123`		`- BOOST_REQUIRE_EQUAL(ec.message(), "transaction currently non-final for next block");`
	`123`	`+ BOOST_REQUIRE_EQUAL(ec.message(), "transaction currently non-final");`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`BOOST_AUTO_TEST_CASE(transaction_error_t__code__premature_validation__true_exected_message)`