Merge pull request #1631 from evoskuil/master

evoskuil · web-flow · commit 84b6db6ecf86 · 2025-04-10T00:26:54.000-04:00
Optimize siphash and chain to_data() stream readers.
diff --git a/include/bitcoin/system/impl/stream/iostream/istream.ipp b/include/bitcoin/system/impl/stream/iostream/istream.ipp
@@ -28,6 +28,7 @@ namespace system {
 
 // Allowed here for low level performance benefit.
 BC_PUSH_WARNING(NO_POINTER_ARITHMETIC)
+BC_PUSH_WARNING(NO_UNSAFE_COPY_N)
 
 template <typename Character>
 template <typename Buffer>
@@ -150,18 +151,19 @@ template <typename Character>
 void
 istream<Character>::read(char_type* data, std::streamsize count) NOEXCEPT
 {
-    const auto bytes = possible_narrow_sign_cast<size_t>(count);
+    auto bytes = possible_narrow_sign_cast<size_t>(count);
 
     if (is_overflow(bytes))
     {
+        if (state_ != goodbit)
+            return;
+
+        // Allow read to end if state was good (std::istream behavior).
+        bytes = end_ - position_;
         setstate(badbit);
-        return;
     }
 
-    BC_PUSH_WARNING(NO_UNSAFE_COPY_N)
     std::copy_n(position_, bytes, data);
-    BC_POP_WARNING()
-
     position_ += bytes;
 }
 
@@ -181,6 +183,7 @@ istream<Character>::is_overflow(pos_type size) const NOEXCEPT
     return (state_ != goodbit) || (size > (end_ - position_));
 }
 
+BC_POP_WARNING()
 BC_POP_WARNING()
 
 } // namespace system
diff --git a/src/chain/block.cpp b/src/chain/block.cpp
@@ -167,8 +167,9 @@ size_t block::get_allocation() const NOEXCEPT
 data_chunk block::to_data(bool witness) const NOEXCEPT
 {
     data_chunk data(serialized_size(witness));
-    stream::out::copy ostream(data);
-    to_data(ostream, witness);
+    stream::out::fast ostream(data);
+    write::bytes::fast out(ostream);
+    to_data(out, witness);
     return data;
 }
 
diff --git a/src/chain/header.cpp b/src/chain/header.cpp
@@ -165,12 +165,9 @@ void header::assign_data(reader& source) NOEXCEPT
 data_chunk header::to_data() const NOEXCEPT
 {
     data_chunk data(serialized_size());
-
-    BC_PUSH_WARNING(NO_THROW_IN_NOEXCEPT)
-    stream::out::copy ostream(data);
-    BC_POP_WARNING()
-
-    to_data(ostream);
+    stream::out::fast ostream(data);
+    write::bytes::fast out(ostream);
+    to_data(out);
     return data;
 }
 
diff --git a/src/chain/input.cpp b/src/chain/input.cpp
@@ -243,8 +243,9 @@ bool operator!=(const cref_point& left, const cref_point& right) NOEXCEPT
 data_chunk input::to_data() const NOEXCEPT
 {
     data_chunk data(serialized_size(false));
-    stream::out::copy ostream(data);
-    to_data(ostream);
+    stream::out::fast ostream(data);
+    write::bytes::fast out(ostream);
+    to_data(out);
     return data;
 }
 
diff --git a/src/chain/operation.cpp b/src/chain/operation.cpp
@@ -397,12 +397,9 @@ operation operation::from_string(const std::string& mnemonic) NOEXCEPT
 data_chunk operation::to_data() const NOEXCEPT
 {
     data_chunk data(serialized_size());
-
-    BC_PUSH_WARNING(NO_THROW_IN_NOEXCEPT)
-    stream::out::copy ostream(data);
-    BC_POP_WARNING()
-
-    to_data(ostream);
+    stream::out::fast ostream(data);
+    write::bytes::fast out(ostream);
+    to_data(out);
     return data;
 }
 
diff --git a/src/chain/output.cpp b/src/chain/output.cpp
@@ -131,8 +131,9 @@ bool output::operator!=(const output& other) const NOEXCEPT
 data_chunk output::to_data() const NOEXCEPT
 {
     data_chunk data(serialized_size());
-    stream::out::copy ostream(data);
-    to_data(ostream);
+    stream::out::fast ostream(data);
+    write::bytes::fast out(ostream);
+    to_data(out);
     return data;
 }
 
diff --git a/src/chain/point.cpp b/src/chain/point.cpp
@@ -156,12 +156,9 @@ void point::assign_data(reader& source) NOEXCEPT
 data_chunk point::to_data() const NOEXCEPT
 {
     data_chunk data(serialized_size());
-
-    BC_PUSH_WARNING(NO_THROW_IN_NOEXCEPT)
-    stream::out::copy ostream(data);
-    BC_POP_WARNING()
-
-    to_data(ostream);
+    stream::out::fast ostream(data);
+    write::bytes::fast out(ostream);
+    to_data(out);
     return data;
 }
 
diff --git a/src/chain/script.cpp b/src/chain/script.cpp
@@ -307,8 +307,9 @@ script script::from_string(const std::string& mnemonic) NOEXCEPT
 data_chunk script::to_data(bool prefix) const NOEXCEPT
 {
     data_chunk data(serialized_size(prefix));
-    stream::out::copy ostream(data);
-    to_data(ostream, prefix);
+    stream::out::fast ostream(data);
+    write::bytes::fast out(ostream);
+    to_data(out, prefix);
     return data;
 }
 
diff --git a/src/chain/transaction.cpp b/src/chain/transaction.cpp
@@ -243,8 +243,9 @@ data_chunk transaction::to_data(bool witness) const NOEXCEPT
     witness &= segregated_;
 
     data_chunk data(serialized_size(witness));
-    stream::out::copy ostream(data);
-    to_data(ostream, witness);
+    stream::out::fast ostream(data);
+    write::bytes::fast out(ostream);
+    to_data(out, witness);
     return data;
 }
 
diff --git a/src/chain/witness.cpp b/src/chain/witness.cpp
@@ -246,8 +246,9 @@ witness witness::from_string(const std::string& mnemonic) NOEXCEPT
 data_chunk witness::to_data(bool prefix) const NOEXCEPT
 {
     data_chunk data(serialized_size(prefix));
-    stream::out::copy ostream(data);
-    to_data(ostream, prefix);
+    stream::out::fast ostream(data);
+    write::bytes::fast out(ostream);
+    to_data(out, prefix);
     return data;
 }
 
diff --git a/src/hash/siphash.cpp b/src/hash/siphash.cpp
@@ -83,14 +83,16 @@ uint64_t siphash(const siphash_key& key,
 
     constexpr auto eight = sizeof(uint64_t);
     const auto bytes = message.size();
-    read::bytes::copy source(message);
+    stream::in::fast stream(message);
+    read::bytes::fast source(stream);
 
     for (size_t index = eight; index <= bytes; index += eight)
-        compression_round(v0, v1, v2, v3,
-            source.read_8_bytes_little_endian());
+        compression_round(v0, v1, v2, v3, source.read_8_bytes_little_endian());
 
-    auto last = is_zero(bytes % eight) ? 0_u64 :
-        source.read_8_bytes_little_endian();
+    // Read zero to seven remainder bytes (zero padded, fails stream).
+    BC_ASSERT(source);
+    auto last = source.read_8_bytes_little_endian();
+    BC_ASSERT(!source);
 
     last ^= ((bytes % max_encoded_byte_count) << to_bits(sub1(eight)));
     compression_round(v0, v1, v2, v3, last);

Original file line number	Diff line number	Diff line change
`@@ -167,8 +167,9 @@ size_t block::get_allocation() const NOEXCEPT`
`167`	`167`	`data_chunk block::to_data(bool witness) const NOEXCEPT`
`168`	`168`	`{`
`169`	`169`	`data_chunk data(serialized_size(witness));`
`170`		`- stream::out::copy ostream(data);`
`171`		`- to_data(ostream, witness);`
	`170`	`+ stream::out::fast ostream(data);`
	`171`	`+ write::bytes::fast out(ostream);`
	`172`	`+ to_data(out, witness);`
`172`	`173`	`return data;`
`173`	`174`	`}`
`174`	`175`
Original file line number	Diff line number	Diff line change
`@@ -243,8 +243,9 @@ bool operator!=(const cref_point& left, const cref_point& right) NOEXCEPT`
`243`	`243`	`data_chunk input::to_data() const NOEXCEPT`
`244`	`244`	`{`
`245`	`245`	`data_chunk data(serialized_size(false));`
`246`		`- stream::out::copy ostream(data);`
`247`		`- to_data(ostream);`
	`246`	`+ stream::out::fast ostream(data);`
	`247`	`+ write::bytes::fast out(ostream);`
	`248`	`+ to_data(out);`
`248`	`249`	`return data;`
`249`	`250`	`}`
`250`	`251`
Original file line number	Diff line number	Diff line change
`@@ -131,8 +131,9 @@ bool output::operator!=(const output& other) const NOEXCEPT`
`131`	`131`	`data_chunk output::to_data() const NOEXCEPT`
`132`	`132`	`{`
`133`	`133`	`data_chunk data(serialized_size());`
`134`		`- stream::out::copy ostream(data);`
`135`		`- to_data(ostream);`
	`134`	`+ stream::out::fast ostream(data);`
	`135`	`+ write::bytes::fast out(ostream);`
	`136`	`+ to_data(out);`
`136`	`137`	`return data;`
`137`	`138`	`}`
`138`	`139`
Original file line number	Diff line number	Diff line change
`@@ -307,8 +307,9 @@ script script::from_string(const std::string& mnemonic) NOEXCEPT`
`307`	`307`	`data_chunk script::to_data(bool prefix) const NOEXCEPT`
`308`	`308`	`{`
`309`	`309`	`data_chunk data(serialized_size(prefix));`
`310`		`- stream::out::copy ostream(data);`
`311`		`- to_data(ostream, prefix);`
	`310`	`+ stream::out::fast ostream(data);`
	`311`	`+ write::bytes::fast out(ostream);`
	`312`	`+ to_data(out, prefix);`
`312`	`313`	`return data;`
`313`	`314`	`}`
`314`	`315`
Original file line number	Diff line number	Diff line change
`@@ -246,8 +246,9 @@ witness witness::from_string(const std::string& mnemonic) NOEXCEPT`
`246`	`246`	`data_chunk witness::to_data(bool prefix) const NOEXCEPT`
`247`	`247`	`{`
`248`	`248`	`data_chunk data(serialized_size(prefix));`
`249`		`- stream::out::copy ostream(data);`
`250`		`- to_data(ostream, prefix);`
	`249`	`+ stream::out::fast ostream(data);`
	`250`	`+ write::bytes::fast out(ostream);`
	`251`	`+ to_data(out, prefix);`
`251`	`252`	`return data;`
`252`	`253`	`}`
`253`	`254`