Merge pull request #1748 from evoskuil/master

Rename make_shared to move_shared and add emplace_shared, test.

Author: evoskuil

include/bitcoin/system/data/memory.hpp

@@ -32,14 +32,22 @@ BC_PUSH_WARNING(NO_VALUE_OR_CONST_REF_SHARED_PTR)
 
 /// shared_ptr
 /// ---------------------------------------------------------------------------
+/// Some of these are just used to suppress noexcept warnings.
 
 /// Create shared pointer to non-const from moved instance.
 template <typename Type>
-inline std::shared_ptr<Type> make_shared(Type&& value) NOEXCEPT
+inline std::shared_ptr<Type> move_shared(Type&& value) NOEXCEPT
 {
     return std::make_shared<Type>(std::forward<Type>(value));
 }
 
+/// Create shared pointer to an in-place constructed instance.
+template <typename Type, typename ...Args>
+inline std::shared_ptr<Type> emplace_shared(Args&&... args) NOEXCEPT
+{
+    return std::make_shared<Type>(std::forward<Args>(args)...);
+}
+
 /// Create default shared pointer.
 template <typename Type>
 inline std::shared_ptr<Type> to_shared() NOEXCEPT

test/data/memory.cpp

@@ -31,17 +31,26 @@ struct type
     int right;
 };
 
+// emplace_shared
+
+using test_string_shared_ptr = std::shared_ptr<std::string>;
+
+BOOST_AUTO_TEST_CASE(memory__emplace_shared__array_move__expected_values)
+{
+    const test_string_shared_ptr ptr = system::emplace_shared<std::string>("test");
+}
+
 // make_shared
 
 using test_array_shared_ptr = std::shared_ptr<data_array<3>>;
 
 BOOST_AUTO_TEST_CASE(memory__make_shared__array_move__expected_values)
 {
-    const test_array_shared_ptr ptr = make_shared<data_array<3>>(data_array<3>{ 1, 2, 3 });
+    const test_array_shared_ptr ptr = system::move_shared<data_array<3>>(data_array<3>{ 1, 2, 3 });
     BOOST_REQUIRE_EQUAL(ptr->at(0), 1);
     BOOST_REQUIRE_EQUAL(ptr->at(1), 2);
     BOOST_REQUIRE_EQUAL(ptr->at(2), 3);
-}
+} 
 
 // to_shared