Don't use brace init in vector(size) construct.

Author: evoskuil

src/chain/block.cpp

@@ -404,7 +404,7 @@ bool block::is_forward_reference() const NOEXCEPT
     if (txs_->empty())
         return false;
 
-    unordered_set_of_hash_cref hashes{ sub1(txs_->size()) };
+    unordered_set_of_hash_cref hashes(sub1(txs_->size()));
     for (auto tx = txs_->rbegin(); tx != std::prev(txs_->rend()); ++tx)
     {
         for (const auto& in: *(*tx)->inputs_ptr())
@@ -425,7 +425,7 @@ bool block::is_internal_double_spend() const NOEXCEPT
     if (txs_->empty())
         return false;
 
-    unordered_set_of_point_cref points{ spends() };
+    unordered_set_of_point_cref points(spends());
     for (auto tx = std::next(txs_->begin()); tx != txs_->end(); ++tx)
         for (const auto& in: *(*tx)->inputs_ptr())
             if (!points.emplace(in->point()).second)
@@ -507,7 +507,7 @@ bool block::is_hash_limit_exceeded() const NOEXCEPT
         return false;
 
     // A set is used to collapse duplicates.
-    unordered_set_of_hash_cref hashes{ txs_->size() };
+    unordered_set_of_hash_cref hashes(txs_->size());
 
     // Just the coinbase tx hash, skip its null input hashes.
     hashes.emplace(txs_->front()->get_hash(false));
@@ -769,7 +769,7 @@ void block::populate() const NOEXCEPT
     if (txs_->empty())
         return;
 
-    unordered_map_of_cref_point_to_output_cptr_cref points{ outputs() };
+    unordered_map_of_cref_point_to_output_cptr_cref points(outputs());
     uint32_t index{};
 
     // Populate outputs hash table (coinbase included).
@@ -798,7 +798,7 @@ code block::populate_with_metadata(const chain::context& ctx) const NOEXCEPT
         return error::block_success;
 
     const auto bip68 = ctx.is_enabled(chain::flags::bip68_rule);
-    unordered_map_of_cref_point_to_output_cptr_cref points{ outputs() };
+    unordered_map_of_cref_point_to_output_cptr_cref points(outputs());
     uint32_t index{};
 
     // Populate outputs hash table (coinbase included).