Avoid unnecessary function call in is_root_position.

evoskuil · evoskuil · commit 66d8aa3a93dd · 2024-12-21T03:02:24.000-05:00
diff --git a/test/utreexo/utreexo.hpp b/test/utreexo/utreexo.hpp
@@ -127,9 +127,8 @@ constexpr bool is_root_position(uint64_t position, uint64_t leaves,
     uint8_t forest_rows) NOEXCEPT
 {
     const auto row = detect_row(position, forest_rows);
-    const auto present = get_right(leaves, row);
-    const auto expected = root_position(leaves, row, forest_rows);
-    return present && (position == expected);
+    return get_right(leaves, row) &&
+        (position == root_position(leaves, row, forest_rows));
 }
 
 constexpr uint64_t remove_bit(uint64_t value, size_t bit) NOEXCEPT

Original file line number	Diff line number	Diff line change
`@@ -127,9 +127,8 @@ constexpr bool is_root_position(uint64_t position, uint64_t leaves,`
`127`	`127`	`uint8_t forest_rows) NOEXCEPT`
`128`	`128`	`{`
`129`	`129`	`const auto row = detect_row(position, forest_rows);`
`130`		`- const auto present = get_right(leaves, row);`
`131`		`- const auto expected = root_position(leaves, row, forest_rows);`
`132`		`- return present && (position == expected);`
	`130`	`+ return get_right(leaves, row) &&`
	`131`	`+ (position == root_position(leaves, row, forest_rows));`
`133`	`132`	`}`
`134`	`133`
`135`	`134`	`constexpr uint64_t remove_bit(uint64_t value, size_t bit) NOEXCEPT`