Merge pull request #1762 from evoskuil/master

evoskuil · web-flow · commit 1e34c98b229d · 2025-12-01T02:06:51.000-05:00
Invalidate witness for non-witness tx (prevents serialization).
diff --git a/src/chain/witness.cpp b/src/chain/witness.cpp
@@ -205,7 +205,7 @@ void witness::assign_data(reader& source, bool prefix) NOEXCEPT
     if (annex::is_annex_pattern(stack_))
         annex_ = { stack_.back() };
 
-    valid_ = source;
+    valid_ = source && !stack_.empty();
 }
 
 // Serialization.

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ void witness::assign_data(reader& source, bool prefix) NOEXCEPT`
`205`	`205`	`if (annex::is_annex_pattern(stack_))`
`206`	`206`	`annex_ = { stack_.back() };`
`207`	`207`
`208`		`- valid_ = source;`
	`208`	`+ valid_ = source && !stack_.empty();`
`209`	`209`	`}`
`210`	`210`
`211`	`211`	`// Serialization.`