Address PR review comments.

Author: eynhaender

examples/normalization_demo.cpp

@@ -84,9 +84,6 @@
 /// WITH_ build symbols.
 /// ---------------------------------------------------------------------------
 
-/// Unicode normalization is always available (embedded tables, no ICU needed).
-#define HAVE_ICU
-
 /// vc++: There are no flags for SHANI/CRYPTO, so use custom WITH_SHA option.
 #if defined(HAVE_MSC) && defined(WITH_SHA)
     #if defined(HAVE_XCPU)

include/bitcoin/system/have.hpp

@@ -84,15 +84,13 @@ class BC_API electrum
 
     /// Returns true if the seed of the words has the given prefix.
     /// Will also match 'old', 'bip39' and 'none', as specified.
-    /// Non-ascii words must be nfkd/lower prenormalized if HAVE_ICU undefind.
     static bool is_prefix(const string_list& words,
         seed_prefix prefix) NOEXCEPT;
     static bool is_prefix(const std::string& sentence,
         seed_prefix prefix) NOEXCEPT;
 
     /// Obtain the enumerated prefix corresponding to the words.
     /// Returns 'old', 'bip39' or 'none' if not a valid electrum v2 seed.
-    /// Non-ascii words must be nfkd/lower prenormalized if HAVE_ICU undefind.
     /// A prefix other than 'none' implies the words represent a valid seed.
     static seed_prefix to_prefix(const string_list& words) NOEXCEPT;
     static seed_prefix to_prefix(const std::string& sentence) NOEXCEPT;
@@ -135,7 +133,6 @@ class BC_API electrum
     /// Derive raw form "root seed" from mnemonic entropy and passphrase.
     /// The "root seed" is also referred to by electrum as the "master key".
     /// Returns null result if current prefix is 'none', 'bip39, or 'old'.
-    /// Returns null result with non-ascii passphrase and HAVE_ICU undefind.
     long_hash to_seed(const std::string& passphrase="") const NOEXCEPT;
 
     /// Derive hd form "root seed" from mnemonic entropy and passphrase.
@@ -144,7 +141,6 @@ class BC_API electrum
     /// hd_private.secret() + .chain_code() is the raw form "root seed".
     /// Context affects the hd form but does not affect the contained seed.
     /// Returns invalid result if current prefix is 'none', 'bip39, or 'old'.
-    /// Returns invalid result with non-ascii passphrase and HAVE_ICU undefind.
     hd_private to_key(const std::string& passphrase="",
         const context& context=btc_mainnet_p2kh) const NOEXCEPT;
 

include/bitcoin/system/wallet/mnemonics/electrum.hpp

@@ -83,15 +83,13 @@ class BC_API mnemonic
 
     /// wiki.trezor.io/recovery_seed
     /// Derive the "master binary seed" from the "recovery seed" and passphrase.
-    /// Returns null result with non-ascii passphrase and HAVE_ICU undefind.
     long_hash to_seed(const std::string& passphrase="") const NOEXCEPT;
 
     /// wiki.trezor.io/account_private_key
     /// Derive the "account private key" from the "master binary seed".
     /// This is also known as the wallet "root key" or "master private key".
     /// hd_private.to_public() is the "master public key".
     /// The "master binary seed" cannot be obtained from the key.
-    /// Returns invalid result with non-ascii passphrase and HAVE_ICU undefind.
     hd_private to_key(const std::string& passphrase="",
         const context& context=btc_mainnet_p2kh) const NOEXCEPT;
 

include/bitcoin/system/wallet/mnemonics/mnemonic.hpp

@@ -88,7 +88,6 @@ class BC_API languages
         language identifier) NOEXCEPT;
 
     // Normalizes ascii whitespace and attempts nfkd and case lowering.
-    // Both nfkd and case lowering are skipped if HAVE_ICU undefined.
     // This is only used to improve the chance of wordlist matching.
     static string_list try_normalize(const string_list& words) NOEXCEPT;
 

include/bitcoin/system/words/languages.hpp

@@ -211,10 +211,6 @@ DEFINED("HAVE_MEMORY_PRIORITY")
 DEFINED("HAVE_EXECUTION")
 #endif
 
-#ifdef HAVE_ICU
-DEFINED("HAVE_ICU")
-#endif
-
 // These messages are suppressed without this.
 #ifdef HAVE_MESSAGES
 DEFINED("HAVE_MESSAGES")