Skip to content

Admins land in the read-only submission panel from notification 'view more' instead of the review interface #5994

Description

@rtibbles

This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

Admins clicking "view more" on a Community Library submission notification land on the read-only details panel instead of the admin review interface. Route admins straight into the submission modal in review mode with the review side panel open, so they can act on the submission without re-navigating.

Complexity: Low
Target branch: hotfixes

Context

  • "View more" handler: NotificationList.vue:104-109 — hard navigation (window.location.href) to getCommunityLibrarySubmissionDetailsUrl(channelId, submissionId) (shared/utils/helpers.js:660-662), targeting the channelList route /channels/#/community-library/:channelId/:submissionId.
  • That route mounts SubmissionDetailsModal with adminReview: false (channelList/router.js:96-101) — a read-only isolated panel.
  • The administration app already mounts the same SubmissionDetailsModal with adminReview: true (administration/router.js:33-42), which surfaces the "Review" button and ReviewSubmissionSidePanel.vue.
  • Admin status getter: isAdmin at shared/vuex/session/index.js:82-84.

The Change

Preferred direction (lighter than a cross-app redirect):

  • On the existing channelList submission route, pass adminReview conditionally on isAdmin instead of hardcoded false.
  • The admin submission data layer (AdminCommunityLibrarySubmission) should resolve fine since the user is an admin — confirm it loads in this context.

Non-admin users keep the current read-only details panel unchanged.

How to Get There

  1. Log in as an admin user.
  2. Have a Community Library submission notification (a channel version submitted for review).
  3. Open the notifications modal and click "view more" on that notification.
  4. Currently lands on the read-only channelList details panel; expected to land in the admin review modal with the review button available

Out of Scope

  • Non-admin "view more" behavior — keeps the current read-only details panel.
  • Changes to the review actions themselves (ReviewSubmissionSidePanel logic, status transitions, editor notes).
  • Notification content, types, or paging.

Acceptance Criteria

  • Admin clicking "view more" on a Community Library submission notification opens the submission in adminReview mode.
  • The "Review" button and review actions function on this route for admins.
  • Non-admin users still land on the read-only details panel (adminReview: false) — unchanged.
  • adminReview is driven by isAdmin, not hardcoded.
  • PR includes screenshots of the updated admin experience (submission modal + review side panel open).

Testing

  • Manual: verify admin vs non-admin landing as described in How to Get There.
  • Add/adjust component or route tests covering adminReview resolving from isAdmin.

References

  • NotificationList.vue:104-109 — "view more" handler
  • shared/utils/helpers.js:660-662getCommunityLibrarySubmissionDetailsUrl
  • channelList/router.js:96-101 — non-admin submission route (adminReview: false)
  • administration/router.js:33-42 — admin submission route (adminReview: true)
  • shared/views/communityLibrary/SubmissionDetailsModal/index.vueadminReview prop, Review button, side panel
  • administration/components/sidePanels/ReviewSubmissionSidePanel.vue — review UI
  • shared/vuex/session/index.js:82-84isAdmin getter

AI usage

Used Claude Code to map the notifications "view more" flow and the admin review components, and to draft this issue. I directed the design decision (conditional adminReview in place rather than a cross-app redirect), and the code references were located by inspecting the repo. I reviewed and edited the requirements.

Metadata

Metadata

Assignees

Type

No fields configured for Task.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions