lint updates

Author: lanrat

certgraph.go

@@ -25,10 +25,8 @@ import (
 	"github.com/lanrat/certgraph/web"
 )
 
-// version vars
 var (
-	gitDate   = "none"
-	gitHash   = "master"
+	version   = "dev"
 	certGraph = graph.NewCertGraph()
 )
 
@@ -101,7 +99,7 @@ func main() {
 
 	// check for version flag
 	if config.printVersion {
-		fmt.Println(version())
+		fmt.Println(showVersion())
 		return
 	}
 
@@ -411,15 +409,15 @@ func visit(domainNode *graph.DomainNode) {
 
 func printNode(domainNode *graph.DomainNode) {
 	if config.details {
-		fmt.Fprintln(os.Stdout, domainNode)
+		_, _ = fmt.Fprintln(os.Stdout, domainNode)
 	} else {
-		fmt.Fprintln(os.Stdout, domainNode.Domain)
+		_, _ = fmt.Fprintln(os.Stdout, domainNode.Domain)
 	}
 	if config.checkDNS && !domainNode.HasDNS {
 		// TODO print this in a better way
 		// TODO for debugging
 		realDomain, _ := dns.ApexDomain(domainNode.Domain)
-		fmt.Fprintf(os.Stdout, "* Missing DNS for: %s\n", realDomain)
+		_, _ = fmt.Fprintf(os.Stdout, "* Missing DNS for: %s\n", realDomain)
 
 	}
 }
@@ -437,7 +435,7 @@ func certNodeFromCertResult(certResult *driver.CertResult) *graph.CertNode {
 // TODO map all config json
 func generateGraphMetadata() map[string]interface{} {
 	data := make(map[string]interface{})
-	data["version"] = version()
+	data["version"] = version
 	data["website"] = "https://lanrat.github.io/certgraph/"
 	data["scan_date"] = time.Now().UTC()
 	data["command"] = strings.Join(os.Args, " ")
@@ -455,8 +453,8 @@ func generateGraphMetadata() map[string]interface{} {
 }
 
 // returns the version string
-func version() string {
-	return fmt.Sprintf("Git commit: %s [%s]", gitDate, gitHash)
+func showVersion() string {
+	return fmt.Sprintf("Version: %s", version)
 }
 
 // cleanInput attempts to parse the input string as a url to extract the hostname

dns/publicsuffix.go

@@ -28,7 +28,7 @@ func UpdatePublicSuffixList(timeout time.Duration) error {
 	if err != nil {
 		return err
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 	newSuffixList := publicsuffix.NewList()
 	_, err = newSuffixList.Load(resp.Body, suffixListParseOptions)
 	suffixList = newSuffixList

driver/censys/censys.go

@@ -161,7 +161,7 @@ func (d *censys) jsonRequest(method, url string, request, response interface{})
 	if err != nil {
 		return err
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	// got an error, decode it
 	if resp.StatusCode != http.StatusOK {

driver/crtsh/crtsh.go

@@ -5,7 +5,6 @@
 // As the API is unofficial and has been reverse engineered it may stop working
 // at any time and comes with no guarantees.
 // view SQL excample: https://crt.sh/?showSQL=Y&exclude=expired&q=
-//
 package crtsh
 
 import (

driver/http/http.go

@@ -108,7 +108,7 @@ func (d *httpDriver) QueryDomain(host string) (driver.Result, error) {
 	if fullStatus != status.GOOD {
 		return results, err // in some rare cases this error can be ignored
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	// set final domain status
 	results.status.Set(resp.Request.URL.Hostname(), status.New(status.GOOD))

driver/save.go

@@ -15,7 +15,7 @@ func CertsToPEMFile(certs []*x509.Certificate, file string) error {
 	if err != nil {
 		return err
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 	for _, cert := range certs {
 		err = pem.Encode(f, &pem.Block{Type: "CERTIFICATE", Bytes: cert.Raw})
 		if err != nil {
@@ -34,7 +34,7 @@ func RawCertToPEMFile(cert []byte, file string) error {
 	if err != nil {
 		return err
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 	err = pem.Encode(f, &pem.Block{Type: "CERTIFICATE", Bytes: cert})
 	return err
 }

driver/smtp/smtp.go

@@ -88,7 +88,7 @@ func (d *smtpDriver) smtpGetCerts(host string) ([]*x509.Certificate, error) {
 	if err != nil {
 		return certs, err
 	}
-	defer conn.Close()
+	defer func() { _ = conn.Close() }()
 	smtp, err := smtp.NewClient(conn, host)
 	if err != nil {
 		return certs, err

graph/graph.go

@@ -42,12 +42,12 @@ func (graph *CertGraph) AddDomain(domainNode *DomainNode) {
 	graph.domains.Store(domainNode.Domain, domainNode)
 }
 
-//NumDomains returns the number of domains in the graph
+// NumDomains returns the number of domains in the graph
 func (graph *CertGraph) NumDomains() int {
 	return graph.numDomains
 }
 
-//DomainDepth returns the maximum depth of the graph from the initial root domains
+// DomainDepth returns the maximum depth of the graph from the initial root domains
 func (graph *CertGraph) DomainDepth() uint {
 	return graph.depth
 }

status/status.go

@@ -100,9 +100,10 @@ func CheckNetErr(err error) DomainStatus {
 	} else {
 		switch t := err.(type) {
 		case *net.OpError:
-			if t.Op == "dial" {
+			switch t.Op {
+			case "dial":
 				return NOHOST
-			} else if t.Op == "read" {
+			case "read":
 				return REFUSED
 			}
 		case syscall.Errno: