Skip to content

Commit c1ffb5b

Browse files
committed
driver: multiple: remove tool fallbacks
These are no longer required, since get_tool now returns the passed in tool when no tool can be found in the yaml file. Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de> (cherry picked from commit 20caff8) Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
1 parent 345f74a commit c1ffb5b

9 files changed

Lines changed: 15 additions & 15 deletions

labgrid/driver/dfudriver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def __attrs_post_init__(self):
1818
super().__attrs_post_init__()
1919
# FIXME make sure we always have an environment or config
2020
if self.target.env:
21-
self.tool = self.target.env.config.get_tool('dfu-util') or 'dfu-util'
21+
self.tool = self.target.env.config.get_tool('dfu-util')
2222
else:
2323
self.tool = 'dfu-util'
2424

labgrid/driver/fastbootdriver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def __attrs_post_init__(self):
3636
super().__attrs_post_init__()
3737
# FIXME make sure we always have an environment or config
3838
if self.target.env:
39-
self.tool = self.target.env.config.get_tool('fastboot') or 'fastboot'
39+
self.tool = self.target.env.config.get_tool('fastboot')
4040
else:
4141
self.tool = 'fastboot'
4242

labgrid/driver/lxausbmuxdriver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class LXAUSBMuxDriver(Driver):
1919
def __attrs_post_init__(self):
2020
super().__attrs_post_init__()
2121
if self.target.env:
22-
self.tool = self.target.env.config.get_tool('usbmuxctl') or 'usbmuxctl'
22+
self.tool = self.target.env.config.get_tool('usbmuxctl')
2323
else:
2424
self.tool = 'usbmuxctl'
2525

labgrid/driver/openocddriver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def __attrs_post_init__(self):
5151

5252
# FIXME make sure we always have an environment or config
5353
if self.target.env:
54-
self.tool = self.target.env.config.get_tool('openocd') or 'openocd'
54+
self.tool = self.target.env.config.get_tool('openocd')
5555
self.config = self.target.env.config.resolve_path_str_or_list(self.config)
5656
self.search = self.target.env.config.resolve_path_str_or_list(self.search)
5757
else:

labgrid/driver/powerdriver.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class SiSPMPowerDriver(Driver, PowerResetMixin, PowerProtocol):
6969
def __attrs_post_init__(self):
7070
super().__attrs_post_init__()
7171
if self.target.env:
72-
self.tool = self.target.env.config.get_tool('sispmctl') or 'sispmctl'
72+
self.tool = self.target.env.config.get_tool('sispmctl')
7373
else:
7474
self.tool = 'sispmctl'
7575

@@ -316,7 +316,7 @@ class USBPowerDriver(Driver, PowerResetMixin, PowerProtocol):
316316
def __attrs_post_init__(self):
317317
super().__attrs_post_init__()
318318
if self.target.env:
319-
self.tool = self.target.env.config.get_tool('uhubctl') or 'uhubctl'
319+
self.tool = self.target.env.config.get_tool('uhubctl')
320320
else:
321321
self.tool = 'uhubctl'
322322

labgrid/driver/quartushpsdriver.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ def __attrs_post_init__(self):
3232

3333
# FIXME make sure we always have an environment or config
3434
if self.target.env:
35-
self.tool = self.target.env.config.get_tool('quartus_hps') or 'quartus_hps'
36-
self.jtag_tool = self.target.env.config.get_tool('jtagconfig') or 'jtagconfig'
35+
self.tool = self.target.env.config.get_tool('quartus_hps')
36+
self.jtag_tool = self.target.env.config.get_tool('jtagconfig')
3737
else:
3838
self.tool = 'quartus_hps'
3939
self.jtag_tool = 'jtagconfig'

labgrid/driver/usbloader.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def __attrs_post_init__(self):
2323
super().__attrs_post_init__()
2424
# FIXME make sure we always have an environment or config
2525
if self.target.env:
26-
self.tool = self.target.env.config.get_tool('mxs-usb-loader') or 'mxs-usb-loader'
26+
self.tool = self.target.env.config.get_tool('mxs-usb-loader')
2727
else:
2828
self.tool = 'mxs-usb-loader'
2929

@@ -60,7 +60,7 @@ def __attrs_post_init__(self):
6060
super().__attrs_post_init__()
6161
# FIXME make sure we always have an environment or config
6262
if self.target.env:
63-
self.tool = self.target.env.config.get_tool('imx-usb-loader') or 'imx-usb-loader'
63+
self.tool = self.target.env.config.get_tool('imx-usb-loader')
6464
else:
6565
self.tool = 'imx-usb-loader'
6666

@@ -99,7 +99,7 @@ def __attrs_post_init__(self):
9999
super().__attrs_post_init__()
100100
# FIXME make sure we always have an environment or config
101101
if self.target.env:
102-
self.tool = self.target.env.config.get_tool('rk-usb-loader') or 'rk-usb-loader'
102+
self.tool = self.target.env.config.get_tool('rk-usb-loader')
103103
else:
104104
self.tool = 'rk-usb-loader'
105105

@@ -163,7 +163,7 @@ def __attrs_post_init__(self):
163163
super().__attrs_post_init__()
164164
# FIXME make sure we always have an environment or config
165165
if self.target.env:
166-
self.tool = self.target.env.config.get_tool('uuu-loader') or 'uuu-loader'
166+
self.tool = self.target.env.config.get_tool('uuu-loader')
167167
else:
168168
self.tool = 'uuu-loader'
169169

@@ -208,7 +208,7 @@ def __attrs_post_init__(self):
208208
super().__attrs_post_init__()
209209
# FIXME make sure we always have an environment or config
210210
if self.target.env:
211-
self.tool = self.target.env.config.get_tool('imx_usb') or 'imx_usb'
211+
self.tool = self.target.env.config.get_tool('imx_usb')
212212
else:
213213
self.tool = 'imx_usb'
214214

labgrid/driver/usbsdmuxdriver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class USBSDMuxDriver(Driver):
2525
def __attrs_post_init__(self):
2626
super().__attrs_post_init__()
2727
if self.target.env:
28-
self.tool = self.target.env.config.get_tool('usbsdmux') or 'usbsdmux'
28+
self.tool = self.target.env.config.get_tool('usbsdmux')
2929
else:
3030
self.tool = 'usbsdmux'
3131

labgrid/driver/usbsdwiredriver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class USBSDWireDriver(Driver):
2121
def __attrs_post_init__(self):
2222
super().__attrs_post_init__()
2323
if self.target.env:
24-
self.tool = self.target.env.config.get_tool('sd-mux-ctrl') or 'sd-mux-ctrl'
24+
self.tool = self.target.env.config.get_tool('sd-mux-ctrl')
2525
else:
2626
self.tool = 'sd-mux-ctrl'
2727

0 commit comments

Comments
 (0)