Skip to content

Commit fe8aef8

Browse files
committed
remove unnecessary dependency
1 parent 5d4f927 commit fe8aef8

3 files changed

Lines changed: 6 additions & 10 deletions

File tree

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"start": "node pdf-service.js"
44
},
55
"dependencies": {
6-
"commander": "^6.1.0",
76
"express": "^4.17.1",
87
"puppeteer": "^5.2.1"
98
},

pdf-service.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
const express = require('express');
22
const puppeteer = require('puppeteer');
3-
const commander = require('commander');
43
const path = require('path');
54
const fs = require('fs');
65
const crypto = require('crypto');
@@ -19,16 +18,19 @@ app.get('/health', (req, res) => {
1918
calls.health++;
2019
console.log('serving /health');
2120
deliverJson(res, {isReady, calls}, isReady ? 200 : 503);
22-
})
21+
});
22+
23+
app.get('/from-html', async (req, res) => {
24+
});
2325

2426
app.get('/from-url', async (req, res) => {
2527
calls.fromUrl++;
26-
const url = req.param('url');
28+
const url = req.query.url;
2729
console.log('/from-url');
2830

2931
if (!url) {
3032
let msg = 'missing parameter: \'url\'';
31-
deliverJson(res, {msg}, 400);
33+
deliverJson(res, {msg, params: req.params}, 400);
3234
return;
3335
}
3436

yarn.lock

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,6 @@ chownr@^1.1.1:
9898
resolved "https://registry.yarnpkg.com/chownr/-/chownr-1.1.4.tgz#6fc9d7b42d32a583596337666e7d08084da2cc6b"
9999
integrity sha512-jJ0bqzaylmJtVnNgzTeSOs8DPavpbYgEr/b0YL8/2GO3xJEhInFmhKMUnEJQjZumK7KXGFhUy89PrsJWlakBVg==
100100

101-
commander@^6.1.0:
102-
version "6.1.0"
103-
resolved "https://registry.yarnpkg.com/commander/-/commander-6.1.0.tgz#f8d722b78103141006b66f4c7ba1e97315ba75bc"
104-
integrity sha512-wl7PNrYWd2y5mp1OK/LhTlv8Ff4kQJQRXXAvF+uU/TPNiVJUxZLRYGj/B0y/lPGAVcSbJqH2Za/cvHmrPMC8mA==
105-
106101
concat-map@0.0.1:
107102
version "0.0.1"
108103
resolved "https://registry.yarnpkg.com/concat-map/-/concat-map-0.0.1.tgz#d8a96bd77fd68df7793a73036a3ba0d5405d477b"

0 commit comments

Comments
 (0)