Skip to content

Commit 3db3886

Browse files
committed
closes page to prevent memory leaking
1 parent b555adc commit 3db3886

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

pdf-service.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,14 @@ app.get('/from-url', async (req, res) => {
7171
let pdfFilePath;
7272
try {
7373
pdfFilePath = await generatePdf(url, req.query.media);
74+
75+
deliverPdfFile(res, pdfFilePath);
7476
} catch (err) {
7577
console.log('/from-url: error generating PDF', e);
7678
let msg = 'failure generating PDF';
79+
7780
deliverJson(res, {msg, err}, 500);
78-
return;
7981
}
80-
81-
deliverPdfFile(res, pdfFilePath);
8282
});
8383

8484
function deliverJson(res, resp, status = 200) {
@@ -131,6 +131,8 @@ async function generatePdf(url, media) {
131131
// landscape: false,
132132
});
133133

134+
page.close();
135+
134136
return pdfFilePath;
135137
}
136138

0 commit comments

Comments
 (0)