Skip to content

Commit 49cf63e

Browse files
authored
bump K8s min version to 1.33 (#3312)
1 parent af2d223 commit 49cf63e

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

version/version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const (
3333
// NOTE: If you are changing this line, please also update the minimum kubernetes
3434
// version listed here:
3535
// https://github.com/knative/docs/blob/main/docs/snippets/prerequisites.md
36-
defaultMinimumVersion = "v1.32.0"
36+
defaultMinimumVersion = "v1.33.0"
3737
)
3838

3939
func getMinimumVersion() string {

version/version_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,16 @@ func TestVersionCheck(t *testing.T) {
4040
wantError bool
4141
}{{
4242
name: "greater version (patch)",
43-
actualVersion: &testVersioner{version: "v1.32.1"},
43+
actualVersion: &testVersioner{version: "v1.33.1"},
4444
}, {
4545
name: "greater version (patch), no v",
46-
actualVersion: &testVersioner{version: "1.32.1"},
46+
actualVersion: &testVersioner{version: "1.33.1"},
4747
}, {
4848
name: "greater version (patch), pre-release",
49-
actualVersion: &testVersioner{version: "1.32.1-kpn-065dce"},
49+
actualVersion: &testVersioner{version: "1.33.1-kpn-065dce"},
5050
}, {
5151
name: "greater version (patch), pre-release with build",
52-
actualVersion: &testVersioner{version: "1.32.1-1095+9689d22dc3121e-dirty"},
52+
actualVersion: &testVersioner{version: "1.33.1-1095+9689d22dc3121e-dirty"},
5353
}, {
5454
name: "greater version (patch), pre-release, envvar override",
5555
actualVersion: &testVersioner{version: "1.15.11-kpn-065dce"},
@@ -60,16 +60,16 @@ func TestVersionCheck(t *testing.T) {
6060
versionOverride: "1.15.11-0",
6161
}, {
6262
name: "greater version (minor)",
63-
actualVersion: &testVersioner{version: "v1.33.0"},
63+
actualVersion: &testVersioner{version: "v1.34.0"},
6464
}, {
6565
name: "same version",
66-
actualVersion: &testVersioner{version: "v1.32.0"},
66+
actualVersion: &testVersioner{version: "v1.33.0"},
6767
}, {
6868
name: "same version with build",
69-
actualVersion: &testVersioner{version: "v1.32.0+k3s.1"},
69+
actualVersion: &testVersioner{version: "v1.33.0+k3s.1"},
7070
}, {
7171
name: "same version with pre-release",
72-
actualVersion: &testVersioner{version: "v1.32.0-k3s.1"},
72+
actualVersion: &testVersioner{version: "v1.33.0-k3s.1"},
7373
}, {
7474
name: "smaller version",
7575
actualVersion: &testVersioner{version: "v1.14.3"},

0 commit comments

Comments
 (0)