review: add comments for decisions

Author: archandatta

server/lib/cdpmonitor/computed.go

@@ -8,6 +8,8 @@ import (
 	"github.com/onkernel/kernel-images/server/lib/events"
 )
 const (
+	// networkIdleDebounce matches Playwright's networkidle heuristic: fire after
+	// 500 ms with no in-flight network requests.
 	networkIdleDebounce  = 500 * time.Millisecond
 	layoutSettledDebounce = 1 * time.Second
 )

server/lib/cdpmonitor/handlers.go

@@ -142,6 +142,11 @@ func (m *Monitor) handleTimelineEvent(params json.RawMessage, sessionID string)
 	m.computed.onLayoutShift()
 }
 
+// handleNetworkRequest publishes network_request events.
+// NOTE: events include raw headers, post_data, and (on response) truncated
+// bodies which may contain cookies, bearer tokens, or other credentials.
+// This mirrors what CDP/DevTools itself exposes. Consumers should treat the
+// event stream as privileged data; opt-in redaction can be added later.
 func (m *Monitor) handleNetworkRequest(params json.RawMessage, sessionID string) {
 	var p cdpNetworkRequestParams
 	if err := json.Unmarshal(params, &p); err != nil {
@@ -156,7 +161,12 @@ func (m *Monitor) handleNetworkRequest(params json.RawMessage, sessionID string)
 		initiatorType = raw.Type
 	}
 
+	// Redirects reuse the same requestId and fire additional requestWillBeSent
+	// events, but only a single loadingFinished fires per chain. Only increment
+	// netPending for genuinely new requests to avoid permanently inflating the
+	// counter and blocking network_idle.
 	m.pendReqMu.Lock()
+	_, isRedirect := m.pendingRequests[p.RequestID]
 	m.pendingRequests[p.RequestID] = networkReqState{
 		sessionID:    sessionID,
 		method:       p.Request.Method,
@@ -180,7 +190,9 @@ func (m *Monitor) handleNetworkRequest(params json.RawMessage, sessionID string)
 	}
 	data, _ := json.Marshal(ev)
 	m.publishEvent(EventNetworkRequest, events.DetailStandard, events.Source{Kind: events.KindCDP}, "Network.requestWillBeSent", data, sessionID)
-	m.computed.onRequest()
+	if !isRedirect {
+		m.computed.onRequest()
+	}
 }
 
 func (m *Monitor) handleResponseReceived(params json.RawMessage, sessionID string) {

server/lib/cdpmonitor/monitor.go

@@ -187,6 +187,9 @@ func (m *Monitor) failPendingCommands() {
 }
 
 // readLoop reads CDP messages, routing responses to pending callers and dispatching events.
+// On read error (WS drop) this goroutine returns. Reconnection is driven by
+// subscribeToUpstream: the UpstreamProvider always pushes a fresh devtools URL
+// when the browser process restarts, so same-URL redial is not needed here.
 func (m *Monitor) readLoop(ctx context.Context) {
 	m.lifeMu.Lock()
 	done := m.done

server/lib/events/filewriter.go

@@ -7,6 +7,10 @@ import (
 	"sync"
 )
 
+// maxLogFileSize is the per-category file size cap. Writes beyond this limit
+// are silently dropped to prevent unbounded disk usage on constrained instances.
+const maxLogFileSize = 64 << 20 // 64 MB
+
 // fileWriter is a JSONL appender keyed by filename. It opens each file lazily
 // on first write (O_APPEND|O_CREATE|O_WRONLY) and serialises all concurrent
 // writes with a single mutex.
@@ -45,6 +49,14 @@ func (fw *fileWriter) Write(filename string, data []byte) error {
 		fw.files[filename] = f
 	}
 
+	info, err := f.Stat()
+	if err != nil {
+		return fmt.Errorf("filewriter: stat: %w", err)
+	}
+	if info.Size() >= maxLogFileSize {
+		return nil // silently drop; cap reached
+	}
+
 	if _, err := f.Write(data); err != nil {
 		return fmt.Errorf("filewriter: write: %w", err)
 	}