fix: raise a ClientError exception for empty responses and JSON parsing errors

Author: fguillot

kanboard.py

@@ -65,7 +65,7 @@ def __init__(
         ignore_hostname_verification: bool = False,
         user_agent: str = "Kanboard Python API Client",
         loop: Optional[asyncio.AbstractEventLoop] = None,
-    ):
+    ) -> None:
         """
         Initialize a new Kanboard API client instance.
 
@@ -134,6 +134,8 @@ def _to_camel_case(snake_str: str) -> str:
 
     @staticmethod
     def _parse_response(response: bytes):
+        if not response:
+            raise ClientError("Empty response from server")
         try:
             body = json.loads(response.decode(errors="ignore"))
 
@@ -142,8 +144,8 @@ def _parse_response(response: bytes):
                 raise ClientError(message)
 
             return body.get("result")
-        except ValueError:
-            return None
+        except ValueError as e:
+            raise ClientError(f"Failed to parse JSON response: {e}")
 
     def _do_request(self, headers: Dict[str, str], body: Dict):
         try:

pyproject.toml

@@ -13,7 +13,6 @@ authors = [
 classifiers = [
     "Intended Audience :: Developers",
     "Intended Audience :: Information Technology",
-    "License :: OSI Approved :: MIT License",
     "Programming Language :: Python",
     "Programming Language :: Python :: 3 :: Only",
 ]

tests/test_kanboard.py

@@ -62,6 +62,19 @@ def test_http_error(self):
         with self.assertRaises(kanboard.ClientError):
             self.client.remote_procedure()
 
+    def test_empty_response_raises_client_error(self):
+        self.urlopen.return_value.read.return_value = b""
+        with self.assertRaises(kanboard.ClientError) as cm:
+            self.client.remote_procedure()
+        self.assertIn("Empty response", str(cm.exception))
+
+    def test_json_parsing_failure(self):
+        body = b"{invalid json}"
+        self.urlopen.return_value.read.return_value = body
+        with self.assertRaises(kanboard.ClientError) as cm:
+            self.client.remote_procedure()
+        self.assertIn("Failed to parse JSON response", str(cm.exception))
+
     def test_application_error(self):
         body = b'{"jsonrpc": "2.0", "error": {"code": -32603, "message": "Internal error"}, "id": 123}'
         self.urlopen.return_value.read.return_value = body