Commit fbfa21b
authored
Merge pull request #1030 from cderici/build-test-and-issue-template
#1030
#### Description
This does two things:
1. Adds a Makefile target called `build-test` that runs the `setup.py sdist` and installs the artifact in a virtual environment and runs a very simple command on it. The purpose of this is to catch the build and runtime dependency problems early on whenever a change is made that'll effect the release down the road (i.e. before it blows up when a new version is released). We add it into a GH action job as well to automatically catch these issues.
For example, having something like this would've saved us from hitting #1025 on the `3.3.1.0` release, which is the sole reason we had to make a new release https://github.com/juju/python-libjuju/releases/tag/3.3.1.1 afterwards.
2. Updates the bug report template and adds `Please provide a simplified reproducer, and if it's possible please refrain from providing a "clone this repository and run the integration tests to see the problem" type of a reproducer. Thanks!`, which is pretty self-explanatory.
#### QA Steps
Just running the make target to see if it succeeds locally should be sufficient to QA this:
```
make build-test
```
And maybe some manual checking for typos in the template message (b/c user-facing) could help.3 files changed
Lines changed: 32 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
28 | 46 | | |
29 | 47 | | |
30 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
43 | 53 | | |
44 | 54 | | |
45 | 55 | | |
| |||
0 commit comments