Skip to content

Commit e34350a

Browse files
committed
a little refactoring
1 parent c026476 commit e34350a

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

juju/machine.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -232,12 +232,11 @@ def dns_name(self):
232232
233233
May return None if no suitable address is found.
234234
"""
235-
for scope in ['public', 'local-cloud']:
236-
addresses = self.safe_data['addresses'] or []
237-
addresses = [address for address in addresses
238-
if address['scope'] == scope]
239-
if addresses:
240-
return addresses[0]['value']
235+
addresses = self.safe_data['addresses'] or []
236+
for address in addresses:
237+
scope = address['scope']
238+
if scope == 'public' or scope == 'local-cloud':
239+
return address['value']
241240
return None
242241

243242
@property

0 commit comments

Comments
 (0)