Commit df709e3
authored
Merge pull request #993 from freyes/fix-syntax
#993
#### Description
The walrus operator (`:=`) was introduced in Python 3.8, the use of it in the `2.9` branch breaks python 3.6 compatibility which is the version used in Ubuntu 18.04 (Bionic).
https://docs.python.org/3/whatsnew/3.8.html#assignment-expressions
#### QA Steps
1. Install python-libjuju in python 3.6
2. python3 -c "import juju.utils"
```
virtualenv -p /usr/bin/python3.6 /tmp/myvenv
source /tmp/myvenv/bin/activate
python3 setup.py install
python3 -c "import juju.utils"
```
All CI tests need to pass.
#### Notes & Discussion
This regression was introduced by #9751 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | | - | |
| 52 | + | |
| 53 | + | |
54 | 54 | | |
55 | | - | |
56 | | - | |
| 55 | + | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| |||
0 commit comments