Skip to content

Commit c526d17

Browse files
committed
Take out obsolete test that breaks the signal handlers
This test (test_explicit_loop_threaded) is added 7 years ago in #63 #63 in the good old days of custom loops in libjuju. Nowadays everything's handled by the asyncio, so I don't think anyone's using this library with a ThreadPoolExecutor anymore. The signal handlers are breaking because of a known issue from Python 3.8 python/cpython#78860.
1 parent a086809 commit c526d17

1 file changed

Lines changed: 0 additions & 27 deletions

File tree

tests/integration/test_model.py

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import string
88
import time
99
import uuid
10-
from concurrent.futures import ThreadPoolExecutor
1110

1211
import mock
1312
import paramiko
@@ -663,32 +662,6 @@ async def mock_AddRelation(*args, **kwargs):
663662
assert isinstance(my_relation, Relation)
664663

665664

666-
async def _deploy_in_loop(new_loop, model_name, jujudata):
667-
new_model = Model(jujudata=jujudata)
668-
await new_model.connect(model_name)
669-
try:
670-
await new_model.deploy('ubuntu', channel='stable')
671-
assert 'ubuntu' in new_model.applications
672-
finally:
673-
await new_model.disconnect()
674-
675-
676-
@base.bootstrapped
677-
async def test_explicit_loop_threaded(event_loop):
678-
async with base.CleanModel() as model:
679-
model_name = model.name
680-
new_loop = jasyncio.new_event_loop()
681-
with ThreadPoolExecutor(1) as executor:
682-
f = executor.submit(
683-
new_loop.run_until_complete,
684-
_deploy_in_loop(new_loop,
685-
model_name,
686-
model._connector.jujudata))
687-
f.result()
688-
await model._wait_for_new('application', 'ubuntu')
689-
assert 'ubuntu' in model.applications
690-
691-
692665
@base.bootstrapped
693666
async def test_store_resources_charm(event_loop):
694667
pytest.skip('Revise: test_store_resources_charm intermittent test failure')

0 commit comments

Comments
 (0)