Skip to content

Commit c4cadfa

Browse files
committed
fixing unit tests
1 parent 3ab6158 commit c4cadfa

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

tests/unit/test_bundle.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ async def test_run_with_charmhub_charm(self, event_loop):
224224
model = mock.Mock()
225225
model._deploy = base.AsyncMock(return_value=None)
226226
model._add_store_resources = base.AsyncMock(return_value=["resource1"])
227+
model.applications = {}
227228

228229
context = mock.Mock()
229230
context.resolve.return_value = "ch:charm1"
@@ -284,7 +285,7 @@ async def test_run_local(self, event_loop):
284285

285286
@pytest.mark.asyncio
286287
async def test_run_no_series(self, event_loop):
287-
change = AddApplicationChange(1, [], params={"charm": "charm",
288+
change = AddApplicationChange(1, [], params={"charm": "cs:charm1",
288289
"series": "",
289290
"application": "application",
290291
"options": "options",
@@ -301,7 +302,7 @@ async def test_run_no_series(self, event_loop):
301302
model.applications = {}
302303

303304
context = mock.Mock()
304-
context.resolve.return_value = "charm1"
305+
context.resolve.return_value = "cs:charm1"
305306
context.trusted = False
306307
context.model = model
307308
context.bundle = {"bundle": "kubernetes"}
@@ -311,11 +312,11 @@ async def test_run_no_series(self, event_loop):
311312

312313
model._add_store_resources.assert_called_once()
313314
model._add_store_resources.assert_called_with("application",
314-
"charm1",
315+
"cs:charm1",
315316
overrides="resources")
316317

317318
model._deploy.assert_called_once()
318-
model._deploy.assert_called_with(charm_url="charm1",
319+
model._deploy.assert_called_with(charm_url="cs:charm1",
319320
application="application",
320321
series="kubernetes",
321322
config="options",
@@ -541,7 +542,7 @@ async def test_run(self, event_loop):
541542
model.add_relation.assert_called_with("endpoint_1", "endpoint_2")
542543

543544
# confirm that it's idempotent
544-
context.resolveRelation.side_effect = ['endpoint_1', 'endpoint_2']
545+
context.resolve_relation = mock.Mock(side_effect=['endpoint_1', 'endpoint_2'])
545546
model.add_relation.reset_mock()
546547
model.add_relation.return_value = None
547548
model.relations = [rel1, rel2]

0 commit comments

Comments
 (0)