Skip to content

Commit c0483ee

Browse files
Merge branch 'master' into gh/730
2 parents 15fe7e3 + fd2d8c4 commit c0483ee

59 files changed

Lines changed: 85368 additions & 94716 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@
186186
same "printed page" as the copyright notice for easier
187187
identification within third-party archives.
188188

189-
Copyright {yyyy} {name of copyright owner}
189+
Copyright 2022 Canonical Ltd.
190190

191191
Licensed under the Apache License, Version 2.0 (the "License");
192192
you may not use this file except in compliance with the License.

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.0.1
1+
3.0.4

docs/changelog.rst

Lines changed: 57 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,74 @@
11
Changelog
22
---------
3+
4+
3.0.4
5+
^^^^^
6+
7+
Wednesday 26th October
8+
9+
## What's Changed
10+
* [JUJU-2027] Local refresh with resoruces by @cderici in https://github.com/juju/python-libjuju/pull/757
11+
* [JUJU-2026] Improve resolve charm by @cderici in https://github.com/juju/python-libjuju/pull/761
12+
* Add owner and data to license file by @arturo-seijas in https://github.com/juju/python-libjuju/pull/760
13+
14+
## New Contributors
15+
* @arturo-seijas made their first contribution in https://github.com/juju/python-libjuju/pull/760
16+
17+
**Full Changelog**: https://github.com/juju/python-libjuju/compare/3.0.3...3.0.4
18+
19+
3.0.3
20+
^^^^^
21+
22+
Saturay October 22 2022
23+
24+
## What's Changed
25+
26+
* Wait for idle arg type check by @cderici in https://github.com/juju/python-libjuju/pull/741
27+
* [JUJU-1970] Revise local refresh by @cderici in https://github.com/juju/python-libjuju/pull/742
28+
* [JUJU-1984] Update facade schemas for juju 3.0-rc1-2 by @cderici in https://github.com/juju/python-libjuju/pull/745
29+
* [JUJU-1992] Fix charmhub series deploy 3.0 by @cderici in https://github.com/juju/python-libjuju/pull/746
30+
* [JUJU-2001] Fix base for local charms and bundles for CharmOrigin 3.0 by @cderici in https://github.com/juju/python-libjuju/pull/749
31+
* [JUJU-2017] Check subordinate field value instead of existence by @cderici in https://github.com/juju/python-libjuju/pull/751
32+
* [JUJU-2018] Update 2.9.36 facades & clients by @cderici in https://github.com/juju/python-libjuju/pull/752
33+
* [JUJU-1705] Make sure the action status is correctly set by @cderici in https://github.com/juju/python-libjuju/pull/753
34+
* [JUJU-2019] Small fixes for 3.0 by @cderici in https://github.com/juju/python-libjuju/pull/754
35+
36+
37+
**Full Changelog**: https://github.com/juju/python-libjuju/compare/3.0.2...3.0.3
38+
39+
3.0.2
40+
^^^^^
41+
42+
Wednesday October 5 2022
43+
44+
## What's Changed
45+
46+
* Model name can now be accessed through model.name by @jack-w-shaw in https://github.com/juju/python-libjuju/pull/702
47+
* [JUJU-1593] Fix `unit.run()` and update the old client codes by @cderici in https://github.com/juju/python-libjuju/pull/710
48+
* Add py.typed marker by @sed-i in https://github.com/juju/python-libjuju/pull/709
49+
* [JUJU-1664] Add force, no-wait, destroy-storage params to app.destroy by @cderici in https://github.com/juju/python-libjuju/pull/714
50+
* snapcraft.io access should use https requests by @addyess in https://github.com/juju/python-libjuju/pull/715
51+
* [JUJU-1680] Add issue and PR templates by @cderici in https://github.com/juju/python-libjuju/pull/718
52+
* [JUJU-1681] Add --attach-storage parameter to model.deploy by @cderici in https://github.com/juju/python-libjuju/pull/720
53+
* [JUJU-1706] Allow waiting for `wait_for_exact_units=0` by @cderici in https://github.com/juju/python-libjuju/pull/723
54+
* [JUJU-1663] Drop Python 3.5 support from python-libjuju by @cderici in https://github.com/juju/python-libjuju/pull/722
55+
* [JUJU-1671] Charmhub url from model config by @cderici in https://github.com/juju/python-libjuju/pull/724
56+
* [JUJU-1733] Revisit unitrun example by @cderici in https://github.com/juju/python-libjuju/pull/725
57+
* [JUJU-1800] Revise the `application.upgrade_charm()` (refresh) by @cderici in https://github.com/juju/python-libjuju/pull/729
58+
* [JUJU-1893] Revisit `charmhub.info()` by @cderici in https://github.com/juju/python-libjuju/pull/737
59+
360
3.0.1
461
^^^^^
562

663
Thursday August 11 2022
764

8-
## What's Changed
965
* [JUJU-1593] Fix `run_actions` and facade issues by @cderici in https://github.com/juju/python-libjuju/pull/706
1066

1167
3.0.0
1268
^^^^^
1369

1470
Tuesday August 9 2022
1571

16-
## What's Changed
17-
1872
Switching to semantic versioning. From this release on, at least the major release number matches
1973
the most recent Juju supported. Hence the jump to `3.0.0` since this release supports `Juju 3.0`.
2074
(This also means that `python-libjuju <= 2.9.11` only support up to `Juju 2.x`)

juju/action.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,16 @@ class Action(model.ModelEntity):
66
def __init__(self, entity_id, model, history_index=-1, connected=True):
77
super().__init__(entity_id, model, history_index, connected)
88
self.results = {}
9+
self._status = self.data['status']
910

1011
@property
1112
def status(self):
12-
return self.data['status']
13+
return self._status
1314

1415
async def fetch_output(self):
15-
self.results = await self.model.get_action_output(self.id)
16+
completed_action = await self.model._get_completed_action(self.id)
17+
self.results = completed_action.output or {}
18+
self._status = completed_action.status
1619

1720
async def wait(self):
1821
self.results or await self.fetch_output()

0 commit comments

Comments
 (0)