Skip to content

Commit 9daf0fa

Browse files
committed
ci: use fail-fast, not continue-on-error
1 parent 74ab0f6 commit 9daf0fa

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

.github/workflows/test.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ jobs:
9797
timeout-minutes: 150
9898
runs-on: ubuntu-latest
9999
strategy:
100+
fail-fast: false
100101
matrix:
101102
python:
102103
# We will reduce the workload to 3.10 to
@@ -114,7 +115,6 @@ jobs:
114115
# * test_ssh
115116
# * ...
116117
# - "3.6/beta"
117-
continue-on-error: false # ultimately fail a run if one of the matrix combinations fails
118118
steps:
119119
- name: Check out code
120120
uses: actions/checkout@v4
@@ -158,14 +158,14 @@ jobs:
158158
- name: Run integration
159159
# Force one single concurrent test
160160
run: tox -e integration
161-
continue-on-error: true # don't fail early, let other matrix combinations get tested
162161

163162
integration-quarantine:
164163
name: Quarantined Integration Tests
165164
needs: [lint, unit-tests]
166165
timeout-minutes: 150
167166
runs-on: ubuntu-latest
168167
strategy:
168+
fail-fast: false
169169
matrix:
170170
python:
171171
- "3.10"
@@ -174,7 +174,6 @@ jobs:
174174
- "3.3/stable"
175175
- "3.4/stable"
176176
- "3.5/stable"
177-
continue-on-error: false # ultimately fail the run if one of the matrix combinations fails
178177
steps:
179178
- name: Check out code
180179
uses: actions/checkout@v3
@@ -189,4 +188,3 @@ jobs:
189188
juju-channel: ${{ matrix.juju }}
190189
- name: Run integration
191190
run: tox -e integration-quarantine
192-
continue-on-error: true # don't fail early, let other matrix combinations get tested

0 commit comments

Comments
 (0)