Merge pull request #751 from cderici/check-subordinate-field-value

#751

#### Description

This checks the `subordinate` field value from `default-release.revision` from charmhub. Previously we were just checking if it exists.

fixes #750


#### QA Steps

```
tox -e integration -- tests/integration/test_charmhub.py::test_subordinate_false_field_exists
```

Author: jujubot

juju/charmhub.py

@@ -38,7 +38,8 @@ async def is_subordinate(self, charm_name):
         url = "{}/v2/charms/info/{}?fields=default-release.revision.subordinate".format(charmhub_url.value, charm_name)
         _response = await self.request_charmhub_with_retry(url, 5)
         response = json.loads(_response.text)
-        return 'subordinate' in response['default-release']['revision']
+        rev_response = response['default-release']['revision']
+        return 'subordinate' in rev_response and rev_response['subordinate']
 
     # TODO (caner) : we should be able to recreate the channel-map through the
     #  api call without needing the CharmHub facade

tests/integration/test_charmhub.py

@@ -121,6 +121,14 @@ async def test_subordinate_charm_zero_units(event_loop):
         assert len(app2.units) == 0
 
 
+@base.bootstrapped
+@pytest.mark.asyncio
+async def test_subordinate_false_field_exists(event_loop):
+    async with base.CleanModel() as model:
+        assert await model.charmhub.is_subordinate("rsyslog-forwarder-ha")
+        assert not await model.charmhub.is_subordinate("mysql-innodb-cluster")
+
+
 @base.bootstrapped
 @pytest.mark.asyncio
 async def test_list_resources(event_loop):