Skip to content

Commit 8315c6a

Browse files
committed
Avoid using the same object for multiple tests
Mutation is evil.
1 parent c1b997f commit 8315c6a

1 file changed

Lines changed: 20 additions & 19 deletions

File tree

tests/integration/test_unit.py

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -81,34 +81,35 @@ async def test_run(event_loop):
8181
await model.wait_for_idle(status="active")
8282

8383
for unit in app.units:
84-
action = await unit.run('unit-get public-address')
85-
assert isinstance(action, Action)
86-
assert action.status == 'pending'
87-
await action.wait()
88-
assert action.status == 'completed'
84+
action1 = await unit.run('unit-get public-address')
85+
assert isinstance(action1, Action)
86+
assert action1.status == 'pending'
87+
await action1.wait()
88+
assert action1.status == 'completed'
8989
break
9090

9191
for unit in app.units:
92-
action = await unit.run('sleep 1', timeout=0.5)
93-
assert isinstance(action, Action)
94-
await action.wait()
95-
assert action.status == 'failed'
92+
action2 = await unit.run('sleep 1', timeout=0.5)
93+
assert isinstance(action2, Action)
94+
await action2.wait()
95+
assert action2.status == 'failed'
9696
break
9797

9898
for unit in app.units:
99-
action = await unit.run('sleep 0.5', timeout=2)
100-
assert isinstance(action, Action)
101-
await action.wait()
102-
assert action.status == 'completed'
99+
action3 = await unit.run('sleep 0.5', timeout=2)
100+
assert isinstance(action3, Action)
101+
await action3.wait()
102+
assert action3.status == 'completed'
103103
break
104104

105105
unit = app.units[0]
106-
action = await unit.run("df -h", timeout=None)
107-
assert action.status == 'pending'
108-
action = await action.wait()
109-
assert action.status == 'completed'
110-
assert action.results
111-
assert action.results['return-code'] == 0
106+
action4 = await unit.run("df -h", timeout=None)
107+
assert action4.status == 'pending'
108+
action5 = await action4.wait()
109+
assert action4 is action5
110+
assert action5.status == 'completed'
111+
assert action5.results
112+
assert action5.results['return-code'] == 0
112113

113114

114115
@base.bootstrapped

0 commit comments

Comments
 (0)