Merge pull request #459 from SimonRichardson/rename-upgrade-charm-refresh

#459

To remain consistent with juju nomenclature, the following redirects
upgrade_charm to refresh. Once juju 3 is released upgrade_charm can be
removed (along with other alias methods), to ensure a clean API.

This is a purely mechanical change.

Author: jujubot

juju/application.py

@@ -394,7 +394,18 @@ async def set_trusted(self, trust):
         log.debug(
             'Setting config for %s: %s', self.name, config)
 
-        return await app_facade.SetApplicationsConfig(args=[{
+        # Unfortunately we have to do this in a lazy fashion, attempting to use
+        # the method early will cause an error. Attempting to call this
+        # dynamically causes issues with how the client code is wired up... we
+        # end up with a missing _toPy attr.
+        # Using a lambda to only throw it away when it's wrong seems a problem
+        # as well.
+        config_method = None
+        if self._facade_version() < 13:
+            config_method = app_facade.SetApplicationsConfig
+        else:
+            config_method = app_facade.SetConfigs
+        return await config_method(args=[{
             "application": self.name,
             "config": config,
         }])
@@ -550,20 +561,20 @@ def update_allocation(self, allocation):
         """
         raise NotImplementedError()
 
-    async def upgrade_charm(
+    async def refresh(
             self, channel=None, force=False, force_series=False, force_units=False,
             path=None, resources=None, revision=None, switch=None):
-        """Upgrade the charm for this application.
+        """Refresh the charm for this application.
 
         :param str channel: Channel to use when getting the charm from the
             charm store, e.g. 'development'
-        :param bool force_series: Upgrade even if series of deployed
+        :param bool force_series: Refresh even if series of deployed
             application is not supported by the new charm
-        :param bool force_units: Upgrade all units immediately, even if in
+        :param bool force_units: Refresh all units immediately, even if in
             error state
-        :param str path: Uprade to a charm located at path
+        :param str path: Refresh to a charm located at path
         :param dict resources: Dictionary of resource name/filepath pairs
-        :param int revision: Explicit upgrade revision
+        :param int revision: Explicit refresh revision
         :param str switch: Crossgrade charm url
 
         """
@@ -671,6 +682,8 @@ async def upgrade_charm(
             lambda: self.data['charm-url'] == charm_url
         )
 
+    upgrade_charm = refresh
+
     async def get_metrics(self):
         """Get metrics for this application's units.