Skip to content

Commit 4a96306

Browse files
authored
Fix _resolve_charm errors (#834)
That are accidentally introduced in #825. * _resolve_charm's force parameter is made optional * fixed the _resolve_charm calls in bundle.py to have less number of variables to unpack onto
1 parent cfc12d9 commit 4a96306

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

juju/bundle.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ async def _resolve_charms(self):
358358
architecture=architecture,
359359
risk=risk,
360360
track=track)
361-
charm_url, charm_origin, _ = await self.model._resolve_charm(charm_url, origin)
361+
charm_url, charm_origin = await self.model._resolve_charm(charm_url, origin)
362362

363363
spec['charm'] = str(charm_url)
364364
else:
@@ -731,7 +731,7 @@ async def run(self, context):
731731
architecture=arch,
732732
risk=ch.risk,
733733
track=ch.track)
734-
identifier, origin, _ = await context.model._resolve_charm(url, origin)
734+
identifier, origin = await context.model._resolve_charm(url, origin)
735735

736736
if identifier is None:
737737
raise JujuError('unknown charm {}'.format(self.charm))

juju/model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1713,7 +1713,7 @@ async def _add_charm(self, charm_url, origin):
17131713
client_facade = client.ClientFacade.from_connection(self.connection())
17141714
return await client_facade.AddCharm(channel=str(origin.risk), url=charm_url, force=False)
17151715

1716-
async def _resolve_charm(self, url, origin, force):
1716+
async def _resolve_charm(self, url, origin, force=False):
17171717
charms_cls = client.CharmsFacade
17181718
if charms_cls.best_facade_version(self.connection()) < 3:
17191719
raise JujuError("resolve charm")
@@ -1753,7 +1753,7 @@ async def _resolve_charm(self, url, origin, force):
17531753
else:
17541754
raise JujuError("Series {} not supported for {}. Only {}".format(origin.series, result.url, supported_series))
17551755

1756-
return charm_url, result.charm_origin
1756+
return result.url, result.charm_origin
17571757

17581758
async def _resolve_architecture(self, url):
17591759
if url.architecture:

0 commit comments

Comments
 (0)