Skip to content

Commit 3f90162

Browse files
committed
Fix _resolve_charm errors
That are accidentally introduced in #825. * _resolve_charm's force parameter is made optional * fixed the _resolve_charm calls in bundle.py to have less number of variables to unpack onto
1 parent b59ef43 commit 3f90162

2 files changed

Lines changed: 5 additions & 12 deletions

File tree

juju/bundle.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -366,10 +366,8 @@ async def _resolve_charms(self):
366366
architecture=architecture,
367367
risk=risk,
368368
track=track)
369-
if not self.model.connection().is_using_old_client and series:
370-
origin.base = client.Base(
371-
channel=utils.get_series_version(series), name='ubuntu')
372-
charm_url, charm_origin, _ = await self.model._resolve_charm(charm_url, origin)
369+
370+
charm_url, charm_origin = await self.model._resolve_charm(charm_url, origin)
373371
spec['charm'] = str(charm_url)
374372
else:
375373
charm_origin = client.CharmOrigin(source=Source.CHARM_HUB.value,
@@ -719,11 +717,7 @@ async def run(self, context):
719717
architecture=arch,
720718
risk=ch.risk,
721719
track=ch.track)
722-
if not context.model.connection().is_using_old_client and self.series:
723-
origin.base = client.Base(
724-
channel=utils.get_series_version(self.series),
725-
name='ubuntu')
726-
identifier, origin, _ = await context.model._resolve_charm(url, origin)
720+
identifier, origin = await context.model._resolve_charm(url, origin)
727721

728722
if identifier is None:
729723
raise JujuError('unknown charm {}'.format(self.charm))

juju/model.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1790,8 +1790,7 @@ async def _add_charm(self, charm_url, origin):
17901790
client_facade = client.ClientFacade.from_connection(self.connection())
17911791
return await client_facade.AddCharm(channel=str(origin.risk), url=charm_url, force=False)
17921792

1793-
1794-
async def _resolve_charm(self, url, origin, force):
1793+
async def _resolve_charm(self, url, origin, force=False):
17951794
"""Calls Charms.ResolveCharms to resolve all the fields of the
17961795
charm_origin and also the url and the supported_series
17971796
@@ -1844,7 +1843,7 @@ async def _resolve_charm(self, url, origin, force):
18441843
else:
18451844
raise JujuError("Series {} not supported for {}. Only {}".format(origin.series, result.url, supported_series))
18461845

1847-
return charm_url, result.charm_origin
1846+
return result.url, result.charm_origin
18481847

18491848
async def _resolve_architecture(self, url):
18501849
if url.architecture:

0 commit comments

Comments
 (0)